diff options
| author | Brett Wilson <brettw@chromium.org> | 2014-09-19 14:24:40 -0700 |
|---|---|---|
| committer | Brett Wilson <brettw@chromium.org> | 2014-09-19 21:26:05 +0000 |
| commit | 0380637c0085884d209fbbcaf0f0b0871fac162a (patch) | |
| tree | 829e19b2ff79b776205534b4ea82d208d41561dc /sync | |
| parent | ce5f7d429fde7fe62a83735658b54624b7077387 (diff) | |
| download | chromium_src-0380637c0085884d209fbbcaf0f0b0871fac162a.zip chromium_src-0380637c0085884d209fbbcaf0f0b0871fac162a.tar.gz chromium_src-0380637c0085884d209fbbcaf0f0b0871fac162a.tar.bz2 | |
Improve GN header checker, make "check" on //ui/* pass.
I went through and made "gn check //ui/*" pass, and did a lot of enhancements for the bugs I found.
Fixes a big bug in the header checker where it did not consider direct private dependencies to be OK from a header include perspective. However, private deps only change things when there are intermediate targets. This patch marks direct deps OK, and changes the variable names from is_public to is_permitted (since it may not actually be public).
Allow includes to be permitted if any target allows the include, rather than all of them. This happens if multiple targets have the same file as sources.
Strip the generated file directory from the beginning of sources. Previously, this was only for outputs (since typically they're included assuming the root gen dir is on the path). This comes up when an action generates a file, and then it's put into a source set (which we do a lot). This change allows a public dependency on the source set to count for header include purposes.
Track public/private deps in the dependency path finder so the error message can show which deps are private that break the chain. This was really helpful when tracking down errors.
Add deps and public deps to the build to make check pass.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/584683002
Cr-Commit-Position: refs/heads/master@{#295783}
Diffstat (limited to 'sync')
| -rw-r--r-- | sync/BUILD.gn | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sync/BUILD.gn b/sync/BUILD.gn index 0398c22..948f18a 100644 --- a/sync/BUILD.gn +++ b/sync/BUILD.gn @@ -5,11 +5,10 @@ import("//build/config/features.gni") component("sync") { - deps = [ + public_deps = [ ":sync_core", "//sync/protocol", ] - forward_dependent_configs_from = [ "//sync/protocol" ] } # GYP version: sync/sync.gyp:sync_core |