diff options
author | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-06 23:22:33 +0000 |
---|---|---|
committer | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-06 23:22:33 +0000 |
commit | f3d8ca5cd62ee4a0894f94f14df71ae5089d0c36 (patch) | |
tree | 5342f8eacfb1fec85a9bcc90d03b092017750dc9 /sync | |
parent | 6ad827ae1cfbf26a7edac399a082061848e47fb3 (diff) | |
download | chromium_src-f3d8ca5cd62ee4a0894f94f14df71ae5089d0c36.zip chromium_src-f3d8ca5cd62ee4a0894f94f14df71ae5089d0c36.tar.gz chromium_src-f3d8ca5cd62ee4a0894f94f14df71ae5089d0c36.tar.bz2 |
Refactor SyncManager::Init to use a GURL for the sync server URL.
Instead of passing the sync server URL as a string, int, and bool, just
pass the GURL. In a future CL SyncManager will make use of this GURL to
initialize an AttachmentUploader.
clang-format was used to format the modified lines.
BUG=
Review URL: https://codereview.chromium.org/442403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287893 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync')
-rw-r--r-- | sync/internal_api/public/sync_manager.h | 10 | ||||
-rw-r--r-- | sync/internal_api/public/test/fake_sync_manager.h | 6 | ||||
-rw-r--r-- | sync/internal_api/sync_backup_manager.cc | 36 | ||||
-rw-r--r-- | sync/internal_api/sync_backup_manager.h | 8 | ||||
-rw-r--r-- | sync/internal_api/sync_backup_manager_unittest.cc | 19 | ||||
-rw-r--r-- | sync/internal_api/sync_manager_impl.cc | 13 | ||||
-rw-r--r-- | sync/internal_api/sync_manager_impl.h | 9 | ||||
-rw-r--r-- | sync/internal_api/sync_manager_impl_unittest.cc | 9 | ||||
-rw-r--r-- | sync/internal_api/sync_rollback_manager.cc | 36 | ||||
-rw-r--r-- | sync/internal_api/sync_rollback_manager.h | 9 | ||||
-rw-r--r-- | sync/internal_api/sync_rollback_manager_base_unittest.cc | 22 | ||||
-rw-r--r-- | sync/internal_api/sync_rollback_manager_unittest.cc | 26 | ||||
-rw-r--r-- | sync/internal_api/test/fake_sync_manager.cc | 6 | ||||
-rw-r--r-- | sync/tools/sync_client.cc | 40 |
14 files changed, 132 insertions, 117 deletions
diff --git a/sync/internal_api/public/sync_manager.h b/sync/internal_api/public/sync_manager.h index 1af3bf8..0b01232 100644 --- a/sync/internal_api/public/sync_manager.h +++ b/sync/internal_api/public/sync_manager.h @@ -33,6 +33,8 @@ #include "sync/internal_api/public/util/weak_handle.h" #include "sync/protocol/sync_protocol_error.h" +class GURL; + namespace sync_pb { class EncryptedData; } // namespace sync_pb @@ -227,9 +229,7 @@ class SYNC_EXPORT SyncManager { // does not already exist. Returns false on failure. // |event_handler| is the JsEventHandler used to propagate events to // chrome://sync-internals. |event_handler| may be uninitialized. - // |sync_server_and_path| and |sync_server_port| represent the Chrome sync - // server to use, and |use_ssl| specifies whether to communicate securely; - // the default is false. + // |service_url| is the URL of the Chrome Sync Server. // |post_factory| will be owned internally and used to create // instances of an HttpPostProvider. // |model_safe_worker| ownership is given to the SyncManager. @@ -252,9 +252,7 @@ class SYNC_EXPORT SyncManager { virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, diff --git a/sync/internal_api/public/test/fake_sync_manager.h b/sync/internal_api/public/test/fake_sync_manager.h index aff0d41..3fb2a7a 100644 --- a/sync/internal_api/public/test/fake_sync_manager.h +++ b/sync/internal_api/public/test/fake_sync_manager.h @@ -13,6 +13,8 @@ #include "sync/internal_api/public/test/null_sync_context_proxy.h" #include "sync/internal_api/public/test/test_user_share.h" +class GURL; + namespace base { class SequencedTaskRunner; } @@ -78,9 +80,7 @@ class FakeSyncManager : public SyncManager { virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, diff --git a/sync/internal_api/sync_backup_manager.cc b/sync/internal_api/sync_backup_manager.cc index 3295568..0e71f3b 100644 --- a/sync/internal_api/sync_backup_manager.cc +++ b/sync/internal_api/sync_backup_manager.cc @@ -8,6 +8,7 @@ #include "sync/internal_api/public/write_transaction.h" #include "sync/syncable/directory.h" #include "sync/syncable/mutable_entry.h" +#include "url/gurl.h" namespace syncer { @@ -19,25 +20,22 @@ SyncBackupManager::~SyncBackupManager() { } void SyncBackupManager::Init( - const base::FilePath& database_location, - const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, - scoped_ptr<HttpPostProviderFactory> post_factory, - const std::vector<scoped_refptr<ModelSafeWorker> >& workers, - ExtensionsActivity* extensions_activity, - SyncManager::ChangeDelegate* change_delegate, - const SyncCredentials& credentials, - const std::string& invalidator_client_id, - const std::string& restored_key_for_bootstrapping, - const std::string& restored_keystore_key_for_bootstrapping, - InternalComponentsFactory* internal_components_factory, - Encryptor* encryptor, - scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, - ReportUnrecoverableErrorFunction - report_unrecoverable_error_function, - CancelationSignal* cancelation_signal) { + const base::FilePath& database_location, + const WeakHandle<JsEventHandler>& event_handler, + const GURL& service_url, + scoped_ptr<HttpPostProviderFactory> post_factory, + const std::vector<scoped_refptr<ModelSafeWorker> >& workers, + ExtensionsActivity* extensions_activity, + SyncManager::ChangeDelegate* change_delegate, + const SyncCredentials& credentials, + const std::string& invalidator_client_id, + const std::string& restored_key_for_bootstrapping, + const std::string& restored_keystore_key_for_bootstrapping, + InternalComponentsFactory* internal_components_factory, + Encryptor* encryptor, + scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, + ReportUnrecoverableErrorFunction report_unrecoverable_error_function, + CancelationSignal* cancelation_signal) { if (SyncRollbackManagerBase::InitInternal( database_location, internal_components_factory, diff --git a/sync/internal_api/sync_backup_manager.h b/sync/internal_api/sync_backup_manager.h index aba58e2..a065c87 100644 --- a/sync/internal_api/sync_backup_manager.h +++ b/sync/internal_api/sync_backup_manager.h @@ -8,6 +8,7 @@ #include <set> #include "sync/internal_api/sync_rollback_manager_base.h" +#include "url/gurl.h" namespace syncer { @@ -23,9 +24,7 @@ class SYNC_EXPORT_PRIVATE SyncBackupManager : public SyncRollbackManagerBase { virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, @@ -37,8 +36,7 @@ class SYNC_EXPORT_PRIVATE SyncBackupManager : public SyncRollbackManagerBase { InternalComponentsFactory* internal_components_factory, Encryptor* encryptor, scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, - ReportUnrecoverableErrorFunction - report_unrecoverable_error_function, + ReportUnrecoverableErrorFunction report_unrecoverable_error_function, CancelationSignal* cancelation_signal) OVERRIDE; virtual void SaveChanges() OVERRIDE; virtual SyncStatus GetDetailedStatus() const OVERRIDE; diff --git a/sync/internal_api/sync_backup_manager_unittest.cc b/sync/internal_api/sync_backup_manager_unittest.cc index f197ece..31b8d87 100644 --- a/sync/internal_api/sync_backup_manager_unittest.cc +++ b/sync/internal_api/sync_backup_manager_unittest.cc @@ -16,6 +16,7 @@ #include "sync/test/test_directory_backing_store.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" +#include "url/gurl.h" using ::testing::_; using ::testing::Invoke; @@ -61,11 +62,20 @@ class SyncBackupManagerTest : public syncer::SyncManager::Observer, base::RunLoop run_loop; manager->Init(temp_dir_.path(), MakeWeakHandle(base::WeakPtr<JsEventHandler>()), - "", 0, true, scoped_ptr<HttpPostProviderFactory>().Pass(), + GURL("https://example.com/"), + scoped_ptr<HttpPostProviderFactory>().Pass(), std::vector<scoped_refptr<ModelSafeWorker> >(), - NULL, NULL, SyncCredentials(), "", "", "", &factory, - NULL, scoped_ptr<UnrecoverableErrorHandler>().Pass(), - NULL, NULL); + NULL, + NULL, + SyncCredentials(), + "", + "", + "", + &factory, + NULL, + scoped_ptr<UnrecoverableErrorHandler>().Pass(), + NULL, + NULL); loop_.PostTask(FROM_HERE, run_loop.QuitClosure()); run_loop.Run(); } @@ -157,4 +167,3 @@ TEST_F(SyncBackupManagerTest, FailToInitialize) { } // anonymous namespace } // namespace syncer - diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc index 2e12163..ef614cd 100644 --- a/sync/internal_api/sync_manager_impl.cc +++ b/sync/internal_api/sync_manager_impl.cc @@ -50,6 +50,8 @@ using base::TimeDelta; using sync_pb::GetUpdatesCallerInfo; +class GURL; + namespace syncer { using sessions::SyncSessionContext; @@ -304,9 +306,7 @@ void SyncManagerImpl::ConfigureSyncer( void SyncManagerImpl::Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, @@ -384,8 +384,11 @@ void SyncManagerImpl::Init( } connection_manager_.reset(new SyncAPIServerConnectionManager( - sync_server_and_path, port, use_ssl, - post_factory.release(), cancelation_signal)); + service_url.host() + service_url.path(), + service_url.EffectiveIntPort(), + service_url.SchemeIsSecure(), + post_factory.release(), + cancelation_signal)); connection_manager_->set_client_id(directory()->cache_guid()); connection_manager_->AddListener(this); diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h index c23eb38..73c4b71 100644 --- a/sync/internal_api/sync_manager_impl.h +++ b/sync/internal_api/sync_manager_impl.h @@ -29,6 +29,8 @@ #include "sync/util/cryptographer.h" #include "sync/util/time.h" +class GURL; + namespace syncer { class ModelTypeRegistry; @@ -69,9 +71,7 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, @@ -83,8 +83,7 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl InternalComponentsFactory* internal_components_factory, Encryptor* encryptor, scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, - ReportUnrecoverableErrorFunction - report_unrecoverable_error_function, + ReportUnrecoverableErrorFunction report_unrecoverable_error_function, CancelationSignal* cancelation_signal) OVERRIDE; virtual ModelTypeSet InitialSyncEndedTypes() OVERRIDE; virtual ModelTypeSet GetTypesWithEmptyProgressMarkerToken( diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc index 1ecc9ed..148a8ed 100644 --- a/sync/internal_api/sync_manager_impl_unittest.cc +++ b/sync/internal_api/sync_manager_impl_unittest.cc @@ -73,6 +73,7 @@ #include "sync/util/time.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" +#include "url/gurl.h" using base::ExpectDictStringValue; using testing::_; @@ -818,9 +819,7 @@ class SyncManagerTest : public testing::Test, sync_manager_.Init( temp_dir_.path(), WeakHandle<JsEventHandler>(), - "bogus", - 0, - false, + GURL("https://example.com/"), scoped_ptr<HttpPostProviderFactory>(new TestHttpPostProviderFactory()), workers, extensions_activity_.get(), @@ -831,8 +830,8 @@ class SyncManagerTest : public testing::Test, std::string(), // bootstrap tokens scoped_ptr<InternalComponentsFactory>(GetFactory()).get(), &encryptor_, - scoped_ptr<UnrecoverableErrorHandler>( - new TestUnrecoverableErrorHandler).Pass(), + scoped_ptr<UnrecoverableErrorHandler>(new TestUnrecoverableErrorHandler) + .Pass(), NULL, &cancelation_signal_); diff --git a/sync/internal_api/sync_rollback_manager.cc b/sync/internal_api/sync_rollback_manager.cc index c5a6f75..a26e54e 100644 --- a/sync/internal_api/sync_rollback_manager.cc +++ b/sync/internal_api/sync_rollback_manager.cc @@ -11,6 +11,7 @@ #include "sync/internal_api/public/write_transaction.h" #include "sync/syncable/directory.h" #include "sync/syncable/mutable_entry.h" +#include "url/gurl.h" namespace syncer { @@ -22,25 +23,22 @@ SyncRollbackManager::~SyncRollbackManager() { } void SyncRollbackManager::Init( - const base::FilePath& database_location, - const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, - scoped_ptr<HttpPostProviderFactory> post_factory, - const std::vector<scoped_refptr<ModelSafeWorker> >& workers, - ExtensionsActivity* extensions_activity, - SyncManager::ChangeDelegate* change_delegate, - const SyncCredentials& credentials, - const std::string& invalidator_client_id, - const std::string& restored_key_for_bootstrapping, - const std::string& restored_keystore_key_for_bootstrapping, - InternalComponentsFactory* internal_components_factory, - Encryptor* encryptor, - scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, - ReportUnrecoverableErrorFunction - report_unrecoverable_error_function, - CancelationSignal* cancelation_signal) { + const base::FilePath& database_location, + const WeakHandle<JsEventHandler>& event_handler, + const GURL& service_url, + scoped_ptr<HttpPostProviderFactory> post_factory, + const std::vector<scoped_refptr<ModelSafeWorker> >& workers, + ExtensionsActivity* extensions_activity, + SyncManager::ChangeDelegate* change_delegate, + const SyncCredentials& credentials, + const std::string& invalidator_client_id, + const std::string& restored_key_for_bootstrapping, + const std::string& restored_keystore_key_for_bootstrapping, + InternalComponentsFactory* internal_components_factory, + Encryptor* encryptor, + scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, + ReportUnrecoverableErrorFunction report_unrecoverable_error_function, + CancelationSignal* cancelation_signal) { if (SyncRollbackManagerBase::InitInternal( database_location, internal_components_factory, diff --git a/sync/internal_api/sync_rollback_manager.h b/sync/internal_api/sync_rollback_manager.h index fed4fd4..ee71447 100644 --- a/sync/internal_api/sync_rollback_manager.h +++ b/sync/internal_api/sync_rollback_manager.h @@ -10,6 +10,8 @@ #include "sync/internal_api/sync_rollback_manager_base.h" +class GURL; + namespace syncer { // SyncRollbackManager restores user's data to pre-sync state using backup @@ -23,9 +25,7 @@ class SYNC_EXPORT_PRIVATE SyncRollbackManager : public SyncRollbackManagerBase { virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, @@ -37,8 +37,7 @@ class SYNC_EXPORT_PRIVATE SyncRollbackManager : public SyncRollbackManagerBase { InternalComponentsFactory* internal_components_factory, Encryptor* encryptor, scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler, - ReportUnrecoverableErrorFunction - report_unrecoverable_error_function, + ReportUnrecoverableErrorFunction report_unrecoverable_error_function, CancelationSignal* cancelation_signal) OVERRIDE; virtual void StartSyncingNormally( const ModelSafeRoutingInfo& routing_info) OVERRIDE; diff --git a/sync/internal_api/sync_rollback_manager_base_unittest.cc b/sync/internal_api/sync_rollback_manager_base_unittest.cc index 1d4c2de..74ffadc 100644 --- a/sync/internal_api/sync_rollback_manager_base_unittest.cc +++ b/sync/internal_api/sync_rollback_manager_base_unittest.cc @@ -9,6 +9,7 @@ #include "sync/internal_api/public/read_transaction.h" #include "sync/internal_api/public/test/test_internal_components_factory.h" #include "testing/gtest/include/gtest/gtest.h" +#include "url/gurl.h" namespace syncer { @@ -23,9 +24,7 @@ class SyncTestRollbackManager : public SyncRollbackManagerBase { virtual void Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, @@ -53,11 +52,20 @@ class SyncRollbackManagerBaseTest : public testing::Test { STORAGE_IN_MEMORY); manager_.Init(base::FilePath(base::FilePath::kCurrentDirectory), MakeWeakHandle(base::WeakPtr<JsEventHandler>()), - "", 0, true, scoped_ptr<HttpPostProviderFactory>().Pass(), + GURL("https://example.com/"), + scoped_ptr<HttpPostProviderFactory>().Pass(), std::vector<scoped_refptr<ModelSafeWorker> >(), - NULL, NULL, SyncCredentials(), "", "", "", &factory, - NULL, scoped_ptr<UnrecoverableErrorHandler>().Pass(), - NULL, NULL); + NULL, + NULL, + SyncCredentials(), + "", + "", + "", + &factory, + NULL, + scoped_ptr<UnrecoverableErrorHandler>().Pass(), + NULL, + NULL); } SyncTestRollbackManager manager_; diff --git a/sync/internal_api/sync_rollback_manager_unittest.cc b/sync/internal_api/sync_rollback_manager_unittest.cc index 37663f3..73dbac4 100644 --- a/sync/internal_api/sync_rollback_manager_unittest.cc +++ b/sync/internal_api/sync_rollback_manager_unittest.cc @@ -18,6 +18,7 @@ #include "sync/test/test_directory_backing_store.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" +#include "url/gurl.h" using ::testing::_; using ::testing::DoDefault; @@ -114,14 +115,23 @@ class SyncRollbackManagerTest : public testing::Test, storage_option); base::RunLoop run_loop; - manager->Init(temp_dir_.path(), - MakeWeakHandle(base::WeakPtr<JsEventHandler>()), - "", 0, true, scoped_ptr<HttpPostProviderFactory>().Pass(), - std::vector<scoped_refptr<ModelSafeWorker> >(1, - worker_.get()), - NULL, delegate, SyncCredentials(), "", "", "", &factory, - NULL, scoped_ptr<UnrecoverableErrorHandler>().Pass(), - NULL, NULL); + manager->Init( + temp_dir_.path(), + MakeWeakHandle(base::WeakPtr<JsEventHandler>()), + GURL("https://example.com/"), + scoped_ptr<HttpPostProviderFactory>().Pass(), + std::vector<scoped_refptr<ModelSafeWorker> >(1, worker_.get()), + NULL, + delegate, + SyncCredentials(), + "", + "", + "", + &factory, + NULL, + scoped_ptr<UnrecoverableErrorHandler>().Pass(), + NULL, + NULL); loop_.PostTask(FROM_HERE, run_loop.QuitClosure()); run_loop.Run(); } diff --git a/sync/internal_api/test/fake_sync_manager.cc b/sync/internal_api/test/fake_sync_manager.cc index f3e94df..b7e7ba5 100644 --- a/sync/internal_api/test/fake_sync_manager.cc +++ b/sync/internal_api/test/fake_sync_manager.cc @@ -20,6 +20,8 @@ #include "sync/syncable/directory.h" #include "sync/test/fake_sync_encryption_handler.h" +class GURL; + namespace syncer { FakeSyncManager::FakeSyncManager(ModelTypeSet initial_sync_ended_types, @@ -73,9 +75,7 @@ void FakeSyncManager::WaitForSyncThread() { void FakeSyncManager::Init( const base::FilePath& database_location, const WeakHandle<JsEventHandler>& event_handler, - const std::string& sync_server_and_path, - int sync_server_port, - bool use_ssl, + const GURL& service_url, scoped_ptr<HttpPostProviderFactory> post_factory, const std::vector<scoped_refptr<ModelSafeWorker> >& workers, ExtensionsActivity* extensions_activity, diff --git a/sync/tools/sync_client.cc b/sync/tools/sync_client.cc index 34ba338..5ae60d1 100644 --- a/sync/tools/sync_client.cc +++ b/sync/tools/sync_client.cc @@ -46,6 +46,7 @@ #include "sync/test/fake_encryptor.h" #include "sync/tools/invalidation_helper.h" #include "sync/tools/null_invalidation_state_tracker.h" +#include "url/gurl.h" #if defined(OS_MACOSX) #include "base/mac/scoped_nsautorelease_pool.h" @@ -65,6 +66,7 @@ const char kXmppHostPortSwitch[] = "xmpp-host-port"; const char kXmppTrySslTcpFirstSwitch[] = "xmpp-try-ssltcp-first"; const char kXmppAllowInsecureConnectionSwitch[] = "xmpp-allow-insecure-connection"; +const char kSyncServiceURL[] = "https://clients4.google.com/chrome-sync/dev"; // Needed to use a real host resolver. class MyTestURLRequestContext : public net::TestURLRequestContext { @@ -404,9 +406,6 @@ int SyncClientMain(int argc, char* argv[]) { scoped_ptr<SyncManager> sync_manager = sync_manager_factory.CreateSyncManager("sync_client manager"); LoggingJsEventHandler js_event_handler; - const char kSyncServerAndPath[] = "clients4.google.com/chrome-sync/dev"; - int kSyncServerPort = 443; - bool kUseSsl = true; // Used only by InitialProcessMetadata(), so it's okay to leave this as NULL. const scoped_refptr<base::TaskRunner> blocking_task_runner = NULL; const char kUserAgent[] = "sync_client"; @@ -432,25 +431,22 @@ int SyncClientMain(int argc, char* argv[]) { CancelationSignal scm_cancelation_signal; sync_manager->Init(database_dir.path(), - WeakHandle<JsEventHandler>( - js_event_handler.AsWeakPtr()), - kSyncServerAndPath, - kSyncServerPort, - kUseSsl, - post_factory.Pass(), - workers, - extensions_activity, - &change_delegate, - credentials, - invalidator_id, - kRestoredKeyForBootstrapping, - kRestoredKeystoreKeyForBootstrapping, - new InternalComponentsFactoryImpl(factory_switches), - &null_encryptor, - scoped_ptr<UnrecoverableErrorHandler>( - new LoggingUnrecoverableErrorHandler).Pass(), - &LogUnrecoverableErrorContext, - &scm_cancelation_signal); + WeakHandle<JsEventHandler>(js_event_handler.AsWeakPtr()), + GURL(kSyncServiceURL), + post_factory.Pass(), + workers, + extensions_activity, + &change_delegate, + credentials, + invalidator_id, + kRestoredKeyForBootstrapping, + kRestoredKeystoreKeyForBootstrapping, + new InternalComponentsFactoryImpl(factory_switches), + &null_encryptor, + scoped_ptr<UnrecoverableErrorHandler>( + new LoggingUnrecoverableErrorHandler).Pass(), + &LogUnrecoverableErrorContext, + &scm_cancelation_signal); // TODO(akalin): Avoid passing in model parameters multiple times by // organizing handling of model types. invalidator->UpdateCredentials(credentials.email, credentials.sync_token); |