summaryrefslogtreecommitdiffstats
path: root/sync
diff options
context:
space:
mode:
authorrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-23 04:37:44 +0000
committerrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-23 04:37:44 +0000
commitf5f09882760ef0829346d5a5c6747f2820db3248 (patch)
treed736be382083ca93b35fba896ed8117e3a2351fc /sync
parentda45b029b076130513a656622811ac15c2fae5c8 (diff)
downloadchromium_src-f5f09882760ef0829346d5a5c6747f2820db3248.zip
chromium_src-f5f09882760ef0829346d5a5c6747f2820db3248.tar.gz
chromium_src-f5f09882760ef0829346d5a5c6747f2820db3248.tar.bz2
Revert 184257
> Fix net::FileStream to handle all errors correctly. > > This CL adds FileStream::Context::IOResult struct that's used to pass > results of IO operations inside FileStream::Context. Following bugs are > fixes: > > 1. On POSIX net::FileStream::Read() and net::FileStream::Write() would > return a positive result in case of an error. This happens because > POSIX errors are positive integers and FileStream was written with > assumption that they are negative. > 2. On Windows Seek() and Flush() errors were not handled correctly. > This is because CheckForIOError() was assuming that all error codes > are negative, but RecordAndMapError() was mapping positive errors. > 3. On Windows results of asynchronous ReadFile() and WriteFile() were > not handled correctly - ERR_IO_PENDING would be returned even when > operation completes synchronously. > > Also added unittests to check that error codes are handled correctly > now. > > Review URL: https://chromiumcodereview.appspot.com/12320003 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/12328071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184278 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync')
0 files changed, 0 insertions, 0 deletions