diff options
| author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 05:44:19 +0000 |
|---|---|---|
| committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 05:44:19 +0000 |
| commit | 15e2ba2c653a1a8a431653f8b5855e95b2b093c7 (patch) | |
| tree | 478c9829f84f3b00668b89b04008285e49808272 /testing/gtest.gyp | |
| parent | 2abca5b9e4882e98dcec6f4c474f08b62624306a (diff) | |
| download | chromium_src-15e2ba2c653a1a8a431653f8b5855e95b2b093c7.zip chromium_src-15e2ba2c653a1a8a431653f8b5855e95b2b093c7.tar.gz chromium_src-15e2ba2c653a1a8a431653f8b5855e95b2b093c7.tar.bz2 | |
Revert 239423 since it breaks base_unittests in linux, cros, mac valgrind bots.
"""
> Make gtest always use simple internal regex engine.
>
> In order to allow regex matches in gtest to be shared between Windows and other
> systems, we tell gtest to always use it's internal engine.
>
> The syntax supported by the internal engine initially looks like a subset of
> POSIX regexs. However character class shortcuts are not valid POSIX.
>
> Even more confusingly the system POSIX regex function often defines extra
> features not actually part of the standard allowing regex that work on Linux
> fail on Mac OS X.
>
> A search through the code base did not reveal any locations where features not
> supported by the internal regex engine where used.
>
> See bug https://code.google.com/p/chromium/issues/detail?id=317224 for more detailed description.
>
> BUG=317224
>
> Review URL: https://codereview.chromium.org/55983002
TBR=mithro@mithis.com
Review URL: https://codereview.chromium.org/107853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239679 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'testing/gtest.gyp')
| -rw-r--r-- | testing/gtest.gyp | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/testing/gtest.gyp b/testing/gtest.gyp index 486f3e7..517bd06 100644 --- a/testing/gtest.gyp +++ b/testing/gtest.gyp @@ -50,16 +50,6 @@ 'dependencies': [ 'gtest_prod', ], - 'defines': [ - # In order to allow regex matches in gtest to be shared between Windows - # and other systems, we tell gtest to always use it's internal engine. - 'GTEST_HAS_POSIX_RE=0', - ], - 'all_dependent_settings': { - 'defines': [ - 'GTEST_HAS_POSIX_RE=0', - ], - }, 'conditions': [ ['OS == "mac" or OS == "ios"', { 'sources': [ |