diff options
| author | mithro@mithis.com <mithro@mithis.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-05 07:31:46 +0000 |
|---|---|---|
| committer | mithro@mithis.com <mithro@mithis.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-05 07:31:46 +0000 |
| commit | b6c74cd512dd5ce3c42a0862a2de0b36a32fb2be (patch) | |
| tree | eb49a00adebd989f4e51f879194919a8a9994331 /testing | |
| parent | 375ff66e24a0d644a4c3586b7e4c4deac5e80b4e (diff) | |
| download | chromium_src-b6c74cd512dd5ce3c42a0862a2de0b36a32fb2be.zip chromium_src-b6c74cd512dd5ce3c42a0862a2de0b36a32fb2be.tar.gz chromium_src-b6c74cd512dd5ce3c42a0862a2de0b36a32fb2be.tar.bz2 | |
Make gtest always use simple internal regex engine.
In order to allow regex matches in gtest to be shared between Windows and other
systems, we tell gtest to always use it's internal engine.
The syntax supported by the internal engine initially looks like a subset of
POSIX regexs. However character class shortcuts are not valid POSIX.
Even more confusingly the system POSIX regex function often defines extra
features not actually part of the standard allowing regex that work on Linux
fail on Mac OS X.
A search through the code base did not reveal any locations where features not
supported by the internal regex engine where used.
See bug https://code.google.com/p/chromium/issues/detail?id=317224 for more detailed description.
BUG=317224
Review URL: https://codereview.chromium.org/55983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238913 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'testing')
| -rw-r--r-- | testing/gtest.gyp | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/testing/gtest.gyp b/testing/gtest.gyp index 517bd06..486f3e7 100644 --- a/testing/gtest.gyp +++ b/testing/gtest.gyp @@ -50,6 +50,16 @@ 'dependencies': [ 'gtest_prod', ], + 'defines': [ + # In order to allow regex matches in gtest to be shared between Windows + # and other systems, we tell gtest to always use it's internal engine. + 'GTEST_HAS_POSIX_RE=0', + ], + 'all_dependent_settings': { + 'defines': [ + 'GTEST_HAS_POSIX_RE=0', + ], + }, 'conditions': [ ['OS == "mac" or OS == "ios"', { 'sources': [ |