diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 15:04:14 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 15:04:14 +0000 |
| commit | dc3f20a478bb50a5a5c7e7d584115a46b1468aeb (patch) | |
| tree | 6af9d7d96d89a5b3d39c3ae5c4a030194a4074ef /testing | |
| parent | fe8d9364441315dfdc49d7a0b9dfd7dc5f15795c (diff) | |
| download | chromium_src-dc3f20a478bb50a5a5c7e7d584115a46b1468aeb.zip chromium_src-dc3f20a478bb50a5a5c7e7d584115a46b1468aeb.tar.gz chromium_src-dc3f20a478bb50a5a5c7e7d584115a46b1468aeb.tar.bz2 | |
Remove the linux-only CR_SOURCE_ROOT environment variable override of base::DIR_SOURCE_ROOT.
The environment variable overidde was only implemented on linux and not on the
other OSes. So it was not coherent across platforms. I searched for usage and
didn't find anything compelling. If this change causes any breakage, simply
revert it. If is is needed, it should be made coherent between platforms.
Note that this trick is not compatible with test isolation, where test should
find their data file at deterministic relative location, hence the removal of
this override.
R=willchan@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10661019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144460 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'testing')
| -rwxr-xr-x | testing/test_env.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/testing/test_env.py b/testing/test_env.py index bbbcac5..410f812 100755 --- a/testing/test_env.py +++ b/testing/test_env.py @@ -25,14 +25,11 @@ def fix_python_path(cmd): def run_executable(cmd, env): """Runs an executable with: - - environment variable CR_SOURCE_ROOT set to the root directory. - environment variable LANGUAGE to en_US.UTF-8. - Reuses sys.executable automatically. """ # Many tests assume a English interface... env['LANGUAGE'] = 'en_US.UTF-8' - # Used by base/base_paths_linux.cc - env['CR_SOURCE_ROOT'] = os.path.abspath(ROOT_DIR).encode('utf-8') # Ensure paths are correctly separated on windows. cmd[0] = cmd[0].replace('/', os.path.sep) cmd = fix_python_path(cmd) |