diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 22:26:10 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 22:26:10 +0000 |
| commit | a4df4160d29cbaee030d87fce1edaf9c9ba0f2e7 (patch) | |
| tree | e089fb4cb3247041ae2bd28fd1167d96f3b07b89 /testing | |
| parent | b87b28abc78fccf8cd5ad2df0b9d60142c3f6c9c (diff) | |
| download | chromium_src-a4df4160d29cbaee030d87fce1edaf9c9ba0f2e7.zip chromium_src-a4df4160d29cbaee030d87fce1edaf9c9ba0f2e7.tar.gz chromium_src-a4df4160d29cbaee030d87fce1edaf9c9ba0f2e7.tar.bz2 | |
Merge 68638 - Fixes bug where tab/right-arrow to commit results wouldn't always
work. When you press tab/right-arrow we tell the search provider to
update the results. The search provider ignores the request if it was
previously told there are no more results coming. When the location
bar updates (AutocompleteEditController::OnChanged) it tells the
search provider there are no more results coming if whatever it is
loading supports instant. The bug was the existing code was using the
state of what is being displayed when it should have been using the
state of what is being loaded, otherwise if they are different it
prematurely finalizes the search provider so that when we go to commit
it does nothing.
I'm also fixing a bug in LocationBarViewGtk::OnCommitSuggestedText. It
wasn't updating instant and it now needs to.
Lastly I changed windows to not fade out the background if animations
are disabled (this doesn't really fit in with these changes, but I'm
trying to minimize merges).
BUG=65706
TEST=see bug, although this is heavily dependant upon your profile.
Review URL: http://codereview.chromium.org/5659004
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/5511018
git-svn-id: svn://svn.chromium.org/chrome/branches/597/src@68653 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'testing')
0 files changed, 0 insertions, 0 deletions