Remove the IShellLink::Resolve step in ResolveShortcutProperties.

This call was only useful if we cared to have Windows attempt to find the target should the path have moved. Since moving Chrome installs (or installing them on anything but a local C: drive) is unsupported there is no need to do this. This code only cares about the target path currently stored in the shortcut (regardless of its existence) -- for which GetPath() is sufficient.

This call could otherwise take up to 3 seconds per unresolvable shortcut which can drastically impact uninstall times when setup.exe attempts to delete all shortcuts pointing to its chrome.exe in common shortcut paths.

This should also get rid of LOG(ERROR)s in test_installer about unresolveable shortcuts as we will now only inspect the path stored in the shortcut without trying to actually resolve it.

BUG=412380
R=cpu@chromium.org, grt@chromium.org

Review URL: https://codereview.chromium.org/553783005

Cr-Commit-Position: refs/heads/master@{#293986}

0 files changed, 0 insertions, 0 deletions