diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-24 16:45:39 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-24 16:45:39 +0000 |
| commit | 65533ad0606a04de3746da2bc785702ba3da17b5 (patch) | |
| tree | 367ec09508f9fa3fb99989695cec32ad3d8f5a51 /third_party/apple | |
| parent | 6acf8ea52bd70805d70d2f9e2e9e8bb205cbb8bf (diff) | |
| download | chromium_src-65533ad0606a04de3746da2bc785702ba3da17b5.zip chromium_src-65533ad0606a04de3746da2bc785702ba3da17b5.tar.gz chromium_src-65533ad0606a04de3746da2bc785702ba3da17b5.tar.bz2 | |
mac: Fix new clang warnings.
Clang added two warnings:
* It warns on implicit return types for ObjC methods
* It warns if @synthesize is after a method, because that's
apparently a compile error in ARC -- so it's good practice
to do the same in non-ARC mode too, and hence this became a
warning
Both sound like reasonable warnings, so let's just fix them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7493045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93825 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/apple')
| -rw-r--r-- | third_party/apple/ImageAndTextCell.m | 4 | ||||
| -rw-r--r-- | third_party/apple/README.chromium | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/third_party/apple/ImageAndTextCell.m b/third_party/apple/ImageAndTextCell.m index 5e26716..e7e6664 100644 --- a/third_party/apple/ImageAndTextCell.m +++ b/third_party/apple/ImageAndTextCell.m @@ -51,6 +51,8 @@ @implementation ImageAndTextCell +@synthesize image; + - (id)init { if ((self = [super init])) { [self setLineBreakMode:NSLineBreakByTruncatingTail]; @@ -71,8 +73,6 @@ return cell; } -@synthesize image; - - (NSRect)imageRectForBounds:(NSRect)cellFrame { NSRect result; if (image != nil) { diff --git a/third_party/apple/README.chromium b/third_party/apple/README.chromium index fb30109..a1adc03 100644 --- a/third_party/apple/README.chromium +++ b/third_party/apple/README.chromium @@ -3,3 +3,5 @@ URL: http://developer.apple.com/ Local changes: * ImageAndTextCell.h: Changed 'image' property to 'retain' mode to fix a crash. +* ImageAndTextCell.m: Moved '@synthesize' to to the top of '@implementation' as + suggested by a clang warning. |