diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 01:14:55 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 01:14:55 +0000 |
| commit | 7270a3efbc2de4e6704c7f77add5713cdbc15411 (patch) | |
| tree | 39fca8263834cdea1b53a0783ab71209f14a7a6b /third_party/cacheinvalidation | |
| parent | 8ed8d8363d1e6bf2a772086ea04a7ebed3b6bd5c (diff) | |
| download | chromium_src-7270a3efbc2de4e6704c7f77add5713cdbc15411.zip chromium_src-7270a3efbc2de4e6704c7f77add5713cdbc15411.tar.gz chromium_src-7270a3efbc2de4e6704c7f77add5713cdbc15411.tar.bz2 | |
Completely refactor isolate.py to be 'command based'.
Now the .isolate file must be specified with --isolate foo.isolate and the
previous --mode option must be the first argument.
This is similar to the last CL done on trace_inputs.py.
The motivating reason is to be able to add command-specific options.
For example, I want to have 'run' and 'trace' to be able to run parallel jobs,
like trace_test_cases.py. This requires a --jobs argument, and possibly
--whitelist and --blacklist too. Also, this permitted to have mode run doesn't
require --result anymore. So this CL creates a base OptionParserIsolate class
that implements the basic options needed to support any gyp foo_test_run
target, then each command can add other options. This will permit to embed all
trace_test_cases.py and run_test_cases.py functionality.
Move all the code to be exception based instead of passing parser.error
function reference around.
Errors are now consistently printed to stderr.
R=cmp@chromium.org
TBR=thakis@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10582036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143773 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/cacheinvalidation')
| -rw-r--r-- | third_party/cacheinvalidation/cacheinvalidation.gyp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/cacheinvalidation/cacheinvalidation.gyp b/third_party/cacheinvalidation/cacheinvalidation.gyp index d6a01e6..6e4c03e 100644 --- a/third_party/cacheinvalidation/cacheinvalidation.gyp +++ b/third_party/cacheinvalidation/cacheinvalidation.gyp @@ -230,12 +230,12 @@ 'action': [ 'python', '../../tools/isolate/isolate.py', - '--mode', '<(test_isolation_mode)', + '<(test_isolation_mode)', '--outdir', '<(test_isolation_outdir)', '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)', '--variable', 'OS', '<(OS)', '--result', '<@(_outputs)', - 'cacheinvalidation_unittests.isolate', + '--isolate', 'cacheinvalidation_unittests.isolate', ], }, ], |