GN build improvements.

Fixes a TODO about private symbols on GCC.

Moves many third party BUILD.gn files from the secondary tree to the main one.

Fixes the dependencies on Linux so "gn check" passes again.

BUG=367595
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/256153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266932 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 37 insertions, 0 deletions

diff --git a/third_party/expat/BUILD.gn b/third_party/expat/BUILD.gn
new file mode 100644
index 0000000..c58b92e
--- /dev/null
+++ b/third_party/expat/BUILD.gn
@@ -0,0 +1,37 @@
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+if (is_linux) {
+  config("expat_config") {
+    libs = [ "expat" ]
+  }
+
+  group("expat") {
+    direct_dependent_configs = [ ":expat_config" ]
+  }
+
+  # TODO(GYP) Android needs direct dependent includes of
+  # <android_src>/external/expat/lib
+} else {
+  config("expat_config") {
+    include_dirs = [ "files/lib" ]
+    defines = [ "XML_STATIC" ]
+  }
+
+  static_library("expat") {
+    sources = [
+      "files/lib/expat.h",
+      "files/lib/xmlparse.c",
+      "files/lib/xmlrole.c",
+      "files/lib/xmltok.c",
+    ]
+
+    defines = [ "_LIB" ]
+    if (is_win) {
+      defines += [ "COMPILED_FROM_DSP" ]
+    } else {
+      defines += [ "HAVE_EXPAT_CONFIG_H" ]
+    }
+  }
+}