diff options
author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-20 20:12:53 +0000 |
---|---|---|
committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-20 20:12:53 +0000 |
commit | 2778def9d0245d1629cf77a6c35cf2ff7d452c83 (patch) | |
tree | dd5449085d5277075016bd2d77e4a80e0443c644 /third_party/ffmpeg | |
parent | c67afaee8860470a3b716ed595223e0a187a9ade (diff) | |
download | chromium_src-2778def9d0245d1629cf77a6c35cf2ff7d452c83.zip chromium_src-2778def9d0245d1629cf77a6c35cf2ff7d452c83.tar.gz chromium_src-2778def9d0245d1629cf77a6c35cf2ff7d452c83.tar.bz2 |
This CL fixes issue 2674 - Omnibar displays wrong parenthesis for "arabia.msn.com‬"
(http://crbug.com/2674)
The issue is: in RTL locale, the search engine name, if ending with punctuation, might not be displayed correctly in omnibox keyword text and omnibox keyword hint.
Fix: adjust the search engine keyword description (short name) for RTL locale so that the pure LTR search engine name
is marked with LRE-PDF pair to be displayed correctly. For example, "MSN(English)" is displayed as is, not as "(MSN(English".
Reproduce steps:
Looks like the "MSN(English)" is no longer a default search engine name. We can make one by the following steps:
1. Open "customize and control Google Chrome" --> "Options",
2. under "basics" tab, under "Default search:", click "Manage"
3. click on one search engine from the "default search options", then click "edit". For example, pick "AOL".
4. change the "name" from "AOL" to "AOL(English)".
Without the fix, in RTL Chrome, when type in "aol.com" in omnibox, the omni keyword hint shows "(AOL(English - xxxx <tab> yyy" while "xxx" stands for "to search" in Hebrew and "yyy" stands for "press" in Hebrew. After press <tab>, the keyword text in omnibox is ":(AOL(English - zzz" while "zzz" stands for "search" in Hebrew.
With the fix, the name "AOL(English)" is displayed correctly in the above 2 places.
Review URL: http://codereview.chromium.org/21320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10116 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/ffmpeg')
0 files changed, 0 insertions, 0 deletions