Histogram failure reasons for 3 more LevelDB env methods.

This will give us reasons for 6 of the top 7 most common failing methods. RenameFile doesn't have a histogram because base::ReplaceFile only returns a bool. Plumbing an error value is planned.

BUG=225051


Review URL: https://chromiumcodereview.appspot.com/13838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193012 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 6 deletions

diff --git a/third_party/leveldatabase/env_chromium.cc b/third_party/leveldatabase/env_chromium.cc
index d4bb927..6ecdfb1 100644
--- a/third_party/leveldatabase/env_chromium.cc
+++ b/third_party/leveldatabase/env_chromium.cc
@@ -340,8 +340,9 @@ class ChromiumWritableFile : public WritableFile {
   virtual Status Flush() {
     Status result;
     if (HANDLE_EINTR(fflush_unlocked(file_))) {
-      result = Status::IOError(filename_, strerror(errno));
-      uma_logger_->RecordErrorAt(kWritableFileFlush);
+      int saved_errno = errno;
+      result = Status::IOError(filename_, strerror(saved_errno));
+      uma_logger_->RecordSpecificError(kWritableFileFlush, saved_errno);
     }
     return result;
   }
@@ -382,8 +383,9 @@ class ChromiumEnv : public Env, public UMALogger {
     FILE* f = fopen_internal(fname.c_str(), "rb");
     if (f == NULL) {
       *result = NULL;
-      RecordErrorAt(kNewSequentialFile);
-      return Status::IOError(fname, strerror(errno));
+      int saved_errno = errno;
+      RecordSpecificError(kNewSequentialFile, saved_errno);
+      return Status::IOError(fname, strerror(saved_errno));
     } else {
       *result = new ChromiumSequentialFile(fname, f, this);
       return Status::OK();
@@ -614,8 +616,9 @@ class ChromiumEnv : public Env, public UMALogger {
     FILE* f = fopen_internal(fname.c_str(), "w");
     if (f == NULL) {
       *result = NULL;
-      RecordErrorAt(kNewLogger);
-      return Status::IOError(fname, strerror(errno));
+      int saved_errno = errno;
+      RecordSpecificError(kNewLogger, saved_errno);
+      return Status::IOError(fname, strerror(saved_errno));
     } else {
       if (!sync_parent(fname)) {
         fclose(f);
@@ -730,6 +733,9 @@ void ChromiumEnv::InitHistograms(const std::string& uma_title) {
 
   uma_name.append(".");
   MakeErrnoHistogram(uma_name, kWritableFileAppend);
+  MakeErrnoHistogram(uma_name, kNewSequentialFile);
+  MakeErrnoHistogram(uma_name, kWritableFileFlush);
+  MakeErrnoHistogram(uma_name, kNewLogger);
   MakePlatformFileErrorHistogram(uma_name, kNewRandomAccessFile);
   MakePlatformFileErrorHistogram(uma_name, kLockFile);