summaryrefslogtreecommitdiffstats
path: root/third_party/libxml
diff options
context:
space:
mode:
authorscottmg <scottmg@chromium.org>2015-06-30 11:10:29 -0700
committerCommit bot <commit-bot@chromium.org>2015-06-30 18:11:04 +0000
commit838cea57c725da43f9899fee9235fa4fb35bccda (patch)
treebdd06c87cd71b910af69dd5bdeafc1e97ea8e741 /third_party/libxml
parentdcb2830c2eca270550f59e651f793639c7ca8e22 (diff)
downloadchromium_src-838cea57c725da43f9899fee9235fa4fb35bccda.zip
chromium_src-838cea57c725da43f9899fee9235fa4fb35bccda.tar.gz
chromium_src-838cea57c725da43f9899fee9235fa4fb35bccda.tar.bz2
win clang: don't disable -Wself-assign
R=thakis@chromium.org TBR=brettw@chromium.org BUG=505306 Review URL: https://codereview.chromium.org/1218903002 Cr-Commit-Position: refs/heads/master@{#336820}
Diffstat (limited to 'third_party/libxml')
-rw-r--r--third_party/libxml/README.chromium1
-rw-r--r--third_party/libxml/src/xmlschemas.c4
2 files changed, 2 insertions, 3 deletions
diff --git a/third_party/libxml/README.chromium b/third_party/libxml/README.chromium
index 682c659..1b611f0 100644
--- a/third_party/libxml/README.chromium
+++ b/third_party/libxml/README.chromium
@@ -14,6 +14,7 @@ Modifications:
chromium/include/libxml/libxml_utils.h.
- Import https://git.gnome.org/browse/libxml2/commit/?id=7580ce0a7f53891de520fed2c0e360266c286da6
from upstream.
+- Self-assignment removed https://bugzilla.gnome.org/show_bug.cgi?id=751679.
To import a new snapshot:
diff --git a/third_party/libxml/src/xmlschemas.c b/third_party/libxml/src/xmlschemas.c
index 0657b66..971630e 100644
--- a/third_party/libxml/src/xmlschemas.c
+++ b/third_party/libxml/src/xmlschemas.c
@@ -24201,9 +24201,7 @@ xmlSchemaValidateFacets(xmlSchemaAbstractCtxtPtr actxt,
* anySimpleType based types), then use the provided
* type.
*/
- if (val == NULL)
- valType = valType;
- else
+ if (val != NULL)
valType = xmlSchemaGetValType(val);
ret = 0;