diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-04 17:22:29 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-04 17:22:29 +0000 |
| commit | 06ce8802ca1cc98e5e62ec17e4a812e0c9794509 (patch) | |
| tree | 8f78532b6e86430eb40b863a8ab25d4b009f16cd /third_party/sqlite/README.chromium | |
| parent | f0733f1de014f04da70a26899cb430fc73e4f4d9 (diff) | |
| download | chromium_src-06ce8802ca1cc98e5e62ec17e4a812e0c9794509.zip chromium_src-06ce8802ca1cc98e5e62ec17e4a812e0c9794509.tar.gz chromium_src-06ce8802ca1cc98e5e62ec17e4a812e0c9794509.tar.bz2 | |
Only do the exclude-journal-from-Time-Machine-if-the-database-is-excluded
thing for unix-flavored sqlite3 VFSes.
It's wrong to try to do this for the chromium_vfs sqlite3 VFS type. The
exclude code should only be used for databases that are actually on disk.
Under chromium_vfs, zFilename is a name but not a filesystem pathname, and
in the Chromium renderer process, direct filesystem access is forbidden.
The resulting CFURLRef objects did not have valid referents, and on Mac OS
X 10.7 ("Lion"), they resulted in use-after-free and double-free errors.
BUG=91068
TEST=With a clean profile, visit http://www.justgiving.nl/. The page should
not sad tab. Nothing should be logged to the console. Previously,
messages such as the following would be logged:
Google Chrome Helper(12345,0xabcdef00) malloc: *** error for object 0x4545450: incorrect checksum for freed object - object was probably modified after being freed.
Google Chrome Helper(12345,0xabcdef00) malloc: *** error for object 0x4545450: double free
Review URL: http://codereview.chromium.org/7511011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95435 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/sqlite/README.chromium')
| -rw-r--r-- | third_party/sqlite/README.chromium | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/third_party/sqlite/README.chromium b/third_party/sqlite/README.chromium index a38ffda..dd729b8 100644 --- a/third_party/sqlite/README.chromium +++ b/third_party/sqlite/README.chromium @@ -179,11 +179,11 @@ Changes from Chrome: fillInUnixFile(), which will be made static again as soon as a WebKit patch using the new function lands. - From mac_time_machine.patch: - When __APPLE__ and when creating a -journal file, determine if the database - for which the journal is being created has been excluded from being backed - up using Apple's Time Machine and if so then also exclude the journal. These - changes were made in pager.c with includes of Apple interfaces being made in - sqliteInt.h. In order to eliminate a symbol conflict with an Apple library - after amalgamation it was also necessary to rename fts3_porter.c's 'cType' - to 'vOrCType'. + When __APPLE__ and when creating a -journal file with any unix-type vfs, + determine if the database for which the journal is being created has been + excluded from being backed up using Apple's Time Machine and if so then also + exclude the journal. These changes were made in pager.c with includes of + Apple interfaces being made in sqliteInt.h. In order to eliminate a symbol + conflict with an Apple library after amalgamation it was also necessary to + rename fts3_porter.c's 'cType' to 'vOrCType'. - fts3_85522.patch allows fts3 to work if PRAGMA is not authorized. |