summaryrefslogtreecommitdiffstats
path: root/third_party
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-20 23:07:43 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-20 23:07:43 +0000
commit9d3fd748881fc6b4000efea6471b90aead6b5eb1 (patch)
treec38aa09c4146f832c594b87af9893acc66c3d656 /third_party
parenta0265baede5cb109f2afc989b377002323cccb35 (diff)
downloadchromium_src-9d3fd748881fc6b4000efea6471b90aead6b5eb1.zip
chromium_src-9d3fd748881fc6b4000efea6471b90aead6b5eb1.tar.gz
chromium_src-9d3fd748881fc6b4000efea6471b90aead6b5eb1.tar.bz2
libxml: LIBXML_STATIC isn't needed on windows either
In my previous patch today, I moved LIBXML_STATIC into a Windows-only block in the gyp file. It turns out I misread the #defines and it's not needed on any OS. libxml.h has this: #ifndef PIC # define LIBXML_STATIC #endif The PIC define mentioned there appears to be a Linuxism, which is fine for us because we want it to be static anyway. Review URL: http://codereview.chromium.org/2825052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53122 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party')
-rw-r--r--third_party/libxml/libxml.gyp5
1 files changed, 0 insertions, 5 deletions
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 0311df1..2b40342 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -178,11 +178,6 @@
['OS=="mac"', {'defines': ['_REENTRANT']}],
['OS=="win"', {
'product_name': 'libxml2',
- 'defines': [
- # This symbol prevents libxml from marking its functions with
- # __declspec(dllexport).
- 'LIBXML_STATIC',
- ],
}, { # else: OS!="win"
'product_name': 'xml2',
}],