diff options
| author | vitalyp <vitalyp@chromium.org> | 2014-10-02 19:48:51 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-03 02:49:06 +0000 |
| commit | 7e7a8732474e21b6fe9e8d21f0360ded68f49aa2 (patch) | |
| tree | 308407ca73b3830b62b21997279269f05aaeddd3 /third_party | |
| parent | 97865ff398d0eb5f12546e3f6b28d925ad30069d (diff) | |
| download | chromium_src-7e7a8732474e21b6fe9e8d21f0360ded68f49aa2.zip chromium_src-7e7a8732474e21b6fe9e8d21f0360ded68f49aa2.tar.gz chromium_src-7e7a8732474e21b6fe9e8d21f0360ded68f49aa2.tar.bz2 | |
Treat warnings as errors in Closure Compilation
I haven't found an appropriate compiler flag which enables treating warnings as errors.
R=dbeam@chromium.org
CC=tbreisacher@chromium.org
BUG=393873
TEST=misspell some @param name && run gyp && run gyp again
Review URL: https://codereview.chromium.org/622973002
Cr-Commit-Position: refs/heads/master@{#297978}
Diffstat (limited to 'third_party')
| -rwxr-xr-x | third_party/closure_compiler/checker.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py index b471c76..02d9d5b 100755 --- a/third_party/closure_compiler/checker.py +++ b/third_party/closure_compiler/checker.py @@ -211,14 +211,14 @@ class Checker(object): self._debug("Summary: %s" % errors.pop()) output = self._format_errors(map(self._fix_up_error, errors)) - if runner_cmd.returncode: + if errors: self._error("Error in: %s%s" % (source_file, "\n" + output if output else "")) elif output: self._debug("Output: %s" % output) self._clean_up() - return runner_cmd.returncode, output + return bool(errors), output if __name__ == "__main__": |