diff options
| author | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-25 04:31:18 +0000 |
|---|---|---|
| committer | dbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-25 04:31:18 +0000 |
| commit | 8629786b01c0af2c2a20b0136cb3efb28b4d67c1 (patch) | |
| tree | 05c5afab34c02e3aeecb9e8ae840dd619493f50a /third_party | |
| parent | c5283e624d1194a2d4bbdaed06f65be27341ec78 (diff) | |
| download | chromium_src-8629786b01c0af2c2a20b0136cb3efb28b4d67c1.zip chromium_src-8629786b01c0af2c2a20b0136cb3efb28b4d67c1.tar.gz chromium_src-8629786b01c0af2c2a20b0136cb3efb28b4d67c1.tar.bz2 | |
rAc: fix some compile warnings in libaddressinput's tests.
R=rouslan@chromium.org
BUG=340769
Review URL: https://codereview.chromium.org/178323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253074 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party')
3 files changed, 4 insertions, 4 deletions
diff --git a/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc b/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc index 15502f5..9da2183 100644 --- a/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc +++ b/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc @@ -17,8 +17,8 @@ static const char kFakeInsecureUrl[] = "http://example.com"; class ChromeDownloaderImplTest : public testing::Test { public: ChromeDownloaderImplTest() - : success_(false), - fake_factory_(&factory_) {} + : fake_factory_(&factory_), + success_(false) {} virtual ~ChromeDownloaderImplTest() {} protected: diff --git a/third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc b/third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc index d4a337c..ca8e72b 100644 --- a/third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc +++ b/third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc @@ -70,7 +70,7 @@ class AddressUiTest : public testing::TestWithParam<std::string> {}; // Verifies that a region code consists of two characters, for example "TW". TEST_P(AddressUiTest, RegionCodeHasTwoCharacters) { - EXPECT_EQ(2, GetParam().size()); + EXPECT_EQ(2U, GetParam().size()); } // Verifies that BuildComponents() returns valid UI components for a region diff --git a/third_party/libaddressinput/chromium/cpp/test/region_data_constants_test.cc b/third_party/libaddressinput/chromium/cpp/test/region_data_constants_test.cc index 1be5266..6da6fe6 100644 --- a/third_party/libaddressinput/chromium/cpp/test/region_data_constants_test.cc +++ b/third_party/libaddressinput/chromium/cpp/test/region_data_constants_test.cc @@ -28,7 +28,7 @@ class RegionCodeTest : public testing::TestWithParam<std::string> {}; // Verifies that a region code consists of two characters, for example "ZA". TEST_P(RegionCodeTest, RegionCodeHasTwoCharacters) { - EXPECT_EQ(2, GetParam().length()); + EXPECT_EQ(2U, GetParam().length()); } // Test all region codes. |