diff options
| author | epenner@chromium.org <epenner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 22:33:25 +0000 |
|---|---|---|
| committer | epenner@chromium.org <epenner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-20 22:33:25 +0000 |
| commit | b51cfab22d3a5f2c175f56a1d20a557644aa1297 (patch) | |
| tree | 6fbd143526482402f99aedb686a3203aff6ad68b /tools/android | |
| parent | d6a845e8e82060ee7e757bdde46e9c681a46c318 (diff) | |
| download | chromium_src-b51cfab22d3a5f2c175f56a1d20a557644aa1297.zip chromium_src-b51cfab22d3a5f2c175f56a1d20a557644aa1297.tar.gz chromium_src-b51cfab22d3a5f2c175f56a1d20a557644aa1297.tar.bz2 | |
Telemetry: Set scaling governor on all cpus (on all devices)
We try to set the scaling governor for all CPU cores, but
this doesn't work SOCs that dynamically disable cores
entirely (ie. Qualcomm). Since this only happens on Qcomm,
this patch stops the 'mpdecision' process on Qualcomm, which
makes it behave like other devices.
PERF-SHERIFFS: This may improve metrics for the better given
all cores are in 'performance' mode now. It should hopefully
reduce noise, since a different number of cores might have
had 'performance' set on each run, and any code that runs on
a non-performance core will suffer from noisy timings/rates.
Example: Tough-compositor-cases std-dev went from 0.25ms to
0.04ms with this change.
BUG=383566
Review URL: https://codereview.chromium.org/338233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278837 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/android')
| -rw-r--r-- | tools/android/adb_profile_chrome/perf_controller.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/android/adb_profile_chrome/perf_controller.py b/tools/android/adb_profile_chrome/perf_controller.py index 523fb85..aeb29fd 100644 --- a/tools/android/adb_profile_chrome/perf_controller.py +++ b/tools/android/adb_profile_chrome/perf_controller.py @@ -58,7 +58,7 @@ class _PerfProfiler(object): if categories: cmd += ['--event', ','.join(categories)] self._perf_control = perf_control.PerfControl(self._device) - self._perf_control.ForceAllCpusOnline(True) + self._perf_control.SetPerfProfilingMode() self._perf_process = subprocess.Popen(cmd, stdout=self._log_file, stderr=subprocess.STDOUT) @@ -67,7 +67,7 @@ class _PerfProfiler(object): perf_pids = self._device.old_interface.ExtractPid('perf') self._device.RunShellCommand('kill -SIGINT ' + ' '.join(perf_pids)) self._perf_process.wait() - self._perf_control.ForceAllCpusOnline(False) + self._perf_control.SetDefaultPerfMode() def _FailWithLog(self, msg): self._log_file.seek(0) |