diff options
| author | robertocn <robertocn@chromium.org> | 2015-02-05 14:05:53 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-05 22:06:40 +0000 |
| commit | b553efc41b75e7ec0653d17568ee49c9443258bf (patch) | |
| tree | 592569ad36d468bcbe81b444ff3abfffcbd31de4 /tools/auto_bisect | |
| parent | 54e76ef7eff2dae72dbac1c0f7c39aad467a9838 (diff) | |
| download | chromium_src-b553efc41b75e7ec0653d17568ee49c9443258bf.zip chromium_src-b553efc41b75e7ec0653d17568ee49c9443258bf.tar.gz chromium_src-b553efc41b75e7ec0653d17568ee49c9443258bf.tar.bz2 | |
Handling test failures on re-test of good/bad revisions for confidence.
BUG=455467
Review URL: https://codereview.chromium.org/872033003
Cr-Commit-Position: refs/heads/master@{#314891}
Diffstat (limited to 'tools/auto_bisect')
| -rwxr-xr-x | tools/auto_bisect/bisect_perf_regression.py | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py index f30ceb0..db238be 100755 --- a/tools/auto_bisect/bisect_perf_regression.py +++ b/tools/auto_bisect/bisect_perf_regression.py @@ -2480,7 +2480,13 @@ class BisectPerformanceMetrics(object): metric, test_run_multiplier=BORDER_REVISIONS_EXTRA_RUNS) # Is extend the right thing to do here? - state.value['values'].extend(run_results[0]['values']) + if run_results[1] != BUILD_RESULT_FAIL: + state.value['values'].extend(run_results[0]['values']) + else: + warning_text = 'Re-test of revision %s failed with error message: %s' + warning_text %= (state.revision, run_results[0]) + if warning_text not in self.warnings: + self.warnings.append(warning_text) def _IsPlatformSupported(): |