diff options
| author | simonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 19:53:32 +0000 |
|---|---|---|
| committer | simonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 19:53:32 +0000 |
| commit | 6a6f276d6b89a4f96b5f5265de0ff62fbcc27a50 (patch) | |
| tree | 8d56b13f098b928fc80b0f024ae3e565af0e2d8c /tools/bisect-perf-regression.py | |
| parent | 751b13df3b768295e4b215aca45b9f1ea8bd373c (diff) | |
| download | chromium_src-6a6f276d6b89a4f96b5f5265de0ff62fbcc27a50.zip chromium_src-6a6f276d6b89a4f96b5f5265de0ff62fbcc27a50.tar.gz chromium_src-6a6f276d6b89a4f96b5f5265de0ff62fbcc27a50.tar.bz2 | |
Fix perf and build time output. Previously, times reported were a lot smaller than they really were since we weren't filtering out skipped steps and they were getting averaged in with actual build/run times. This is just a fix in output, no changes to logic.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/126253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243369 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/bisect-perf-regression.py')
| -rwxr-xr-x | tools/bisect-perf-regression.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py index 50966c1..0046068 100755 --- a/tools/bisect-perf-regression.py +++ b/tools/bisect-perf-regression.py @@ -1623,7 +1623,7 @@ class BisectPerformanceMetrics(object): if not external_revisions is None: return (results[0], results[1], external_revisions, - time.time() - after_build_time, time.time() - + time.time() - after_build_time, after_build_time - start_build_time) else: return ('Failed to parse DEPS file for external revisions.', @@ -2379,9 +2379,10 @@ class BisectPerformanceMetrics(object): step_build_time_avg = 0.0 step_count = 0.0 for _, current_data in revision_data_sorted: - step_perf_time_avg += current_data['perf_time'] - step_build_time_avg += current_data['build_time'] - step_count += 1 + if current_data['value']: + step_perf_time_avg += current_data['perf_time'] + step_build_time_avg += current_data['build_time'] + step_count += 1 if step_count: step_perf_time_avg = step_perf_time_avg / step_count step_build_time_avg = step_build_time_avg / step_count |