diff options
author | prasadv@chromium.org <prasadv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-11 00:13:12 +0000 |
---|---|---|
committer | prasadv@chromium.org <prasadv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-11 00:13:12 +0000 |
commit | 0e275e143749857bbfc4dbe9d15c46ca184a4942 (patch) | |
tree | 32b627c0cb55296427366cc9af7ed01441e9d014 /tools/bisect-perf-regression.py | |
parent | a51ec8d0a13ea8499b1e22bec93f09e3939a458b (diff) | |
download | chromium_src-0e275e143749857bbfc4dbe9d15c46ca184a4942.zip chromium_src-0e275e143749857bbfc4dbe9d15c46ca184a4942.tar.gz chromium_src-0e275e143749857bbfc4dbe9d15c46ca184a4942.tar.bz2 |
BUG=
NOTRY=True
Review URL: https://codereview.chromium.org/232023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263141 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/bisect-perf-regression.py')
-rwxr-xr-x | tools/bisect-perf-regression.py | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py index 821506a..56892cd 100755 --- a/tools/bisect-perf-regression.py +++ b/tools/bisect-perf-regression.py @@ -1560,9 +1560,12 @@ class BisectPerformanceMetrics(object): return False def IsDownloadable(self, depot): - """Checks if we can download builds for the depot from cloud.""" - return (depot == 'chromium' or 'chromium' in DEPOT_DEPS_NAME[depot]['from'] - or 'v8' in DEPOT_DEPS_NAME[depot]['from']) + """Checks if build is downloadable based on target platform and depot.""" + if self.opts.target_platform in ['chromium'] and self.opts.gs_bucket: + return (depot == 'chromium' or + 'chromium' in DEPOT_DEPS_NAME[depot]['from'] or + 'v8' in DEPOT_DEPS_NAME[depot]['from']) + return False def UpdateDeps(self, revision, depot, deps_file): """Updates DEPS file with new revision of dependency repository. @@ -1749,7 +1752,7 @@ class BisectPerformanceMetrics(object): os.chdir(self.src_cwd) # Fetch build archive for the given revision from the cloud storage when # the storage bucket is passed. - if self.IsDownloadable(depot) and self.opts.gs_bucket and revision: + if self.IsDownloadable(depot) and revision: deps_patch = None if depot != 'chromium': # Create a DEPS patch with new revision for dependency repository. @@ -2260,7 +2263,7 @@ class BisectPerformanceMetrics(object): metric) # Restore build output directory once the tests are done, to avoid # any descrepancy. - if depot == 'chromium' and self.opts.gs_bucket and revision: + if self.IsDownloadable(depot) and revision: self.BackupOrRestoreOutputdirectory(restore=True) if results[1] == 0: |