summaryrefslogtreecommitdiffstats
path: root/tools/checkdeps/checkdeps.py
diff options
context:
space:
mode:
authorjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-31 11:02:18 +0000
committerjoi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-31 11:02:18 +0000
commit55f9f381b265246b184bf4f8b063edd23fe0ce01 (patch)
treee43cac3a5d455a590949db786ce21d5eba2df631 /tools/checkdeps/checkdeps.py
parente68504dac33c871b985769ba0ce2feb5d12eaa43 (diff)
downloadchromium_src-55f9f381b265246b184bf4f8b063edd23fe0ce01.zip
chromium_src-55f9f381b265246b184bf4f8b063edd23fe0ce01.tar.gz
chromium_src-55f9f381b265246b184bf4f8b063edd23fe0ce01.tar.bz2
Add checkdeps presubmit check. Warns on new #includes of dependencies
we are working to eliminate, and errors on new #includes of disallowed dependencies. BUG=138280 Review URL: https://chromiumcodereview.appspot.com/10806049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149167 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/checkdeps/checkdeps.py')
-rwxr-xr-xtools/checkdeps/checkdeps.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/checkdeps/checkdeps.py b/tools/checkdeps/checkdeps.py
index 7661d9d..0b2b7ac 100755
--- a/tools/checkdeps/checkdeps.py
+++ b/tools/checkdeps/checkdeps.py
@@ -340,7 +340,7 @@ class DepsChecker(object):
problems = []
for file_path, include_lines in added_includes:
# TODO(joi): Make this cover Java as well.
- if not os.path.splitext(file_path)[1] in cpp.EXTENSIONS:
+ if not cpp.IsCppFile(file_path):
pass
rules_for_file = GetDirectoryRules(os.path.dirname(file_path))
if rules_for_file: