diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-16 21:56:50 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-16 21:56:50 +0000 |
commit | 7ac273abb24c62e15b882069d228fb7b2de9bf33 (patch) | |
tree | b044cee16b18c198da356a1268205924ab36f96a /tools/checklicenses | |
parent | 23c625fe952f35eb45f8f10b8f6ea9a98a05a922 (diff) | |
download | chromium_src-7ac273abb24c62e15b882069d228fb7b2de9bf33.zip chromium_src-7ac273abb24c62e15b882069d228fb7b2de9bf33.tar.gz chromium_src-7ac273abb24c62e15b882069d228fb7b2de9bf33.tar.bz2 |
Prepare checklicenses.py for buildbot landing.
- suppress yet another regression
- print info how to handle failures
- don't turn the bot red, but orange in case of failure
this is temporary, but will make it significantly easier
to land the buildbot-side change
BUG=28291
Review URL: http://codereview.chromium.org/7925024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101573 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/checklicenses')
-rwxr-xr-x | tools/checklicenses/checklicenses.py | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/tools/checklicenses/checklicenses.py b/tools/checklicenses/checklicenses.py index 2ed79ff..0bd79d0 100755 --- a/tools/checklicenses/checklicenses.py +++ b/tools/checklicenses/checklicenses.py @@ -132,6 +132,9 @@ PATH_SPECIFIC_WHITELISTED_LICENSES = { 'ppapi/lib/gl/include': [ 'UNKNOWN', ], + 'ppapi/native_client/tests/earth/earth_image.inc': [ + 'UNKNOWN', + ], 'remoting/tools/gethosts.sh': [ 'UNKNOWN', ], @@ -416,6 +419,7 @@ def main(options, args): print "Using base directory:", options.base_directory print "Checking:", start_dir + print licensecheck_path = os.path.abspath(os.path.join(options.base_directory, 'third_party', @@ -474,7 +478,16 @@ def main(options, args): sys.exit(0) else: print "\nFAILED\n" - sys.exit(1) + print "Please read", + print "http://www.chromium.org/developers/adding-3rd-party-libraries" + print "for more info how to handle the failure." + print + print "Please respect OWNERS of checklicenses.py. Changes violating" + print "this requirement may be reverted." + + # TODO(phajdan.jr): Switch back to exit(1) when it lands on buildbot. + # 88 is buildbot "warning" code, it doesn't turn the step red but orange. + sys.exit(88) if '__main__' == __name__: |