diff options
| author | estevenson <estevenson@google.com> | 2015-08-18 11:56:39 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-18 18:57:10 +0000 |
| commit | f2c8b28cf9f397a28a41d6121a88ce8c594f447b (patch) | |
| tree | 67e19c51db223b5d898ca0254a584c8d0afa04dc /tools/chrome_extensions | |
| parent | 57daf7e60527375fd5a15fb30948b5be97bebae7 (diff) | |
| download | chromium_src-f2c8b28cf9f397a28a41d6121a88ce8c594f447b.zip chromium_src-f2c8b28cf9f397a28a41d6121a88ce8c594f447b.tar.gz chromium_src-f2c8b28cf9f397a28a41d6121a88ce8c594f447b.tar.bz2 | |
Name change and small null value bug fix.
Changed the name of the extension to "Chromium code coverage: deprecated
UI". Hoping to change the name of
https://chrome-internal.googlesource.com/bling/chromium/+/master/ios_internal/tools/coverage/chrome_extension/
to "Chromium code coverage: Polymer UI".
Also fixed a bug where the coverage stats for previous files were being
used for files that don't have coverage stats, due to a javascript
scoping problem.
BUG=
Review URL: https://codereview.chromium.org/1292783005
Cr-Commit-Position: refs/heads/master@{#343984}
Diffstat (limited to 'tools/chrome_extensions')
| -rw-r--r-- | tools/chrome_extensions/chromium_code_coverage/js/app.js | 5 | ||||
| -rw-r--r-- | tools/chrome_extensions/chromium_code_coverage/manifest.json | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/tools/chrome_extensions/chromium_code_coverage/js/app.js b/tools/chrome_extensions/chromium_code_coverage/js/app.js index b1ed984..322c309 100644 --- a/tools/chrome_extensions/chromium_code_coverage/js/app.js +++ b/tools/chrome_extensions/chromium_code_coverage/js/app.js @@ -116,7 +116,8 @@ coverage.updateUi = function(patchStats, patchElement, reportUrl) { var sourceFileRow = fileRows[i]; var fileName = sourceFileRow.children[2].textContent.trim(); - var incrementalPercent, absolutePercent; + var incrementalPercent = null; + var absolutePercent = null; if (patchStats[fileName]) { incrementalPercent = patchStats[fileName][coverage.INCREMENTAL_COVERAGE]; absolutePercent = patchStats[fileName][coverage.ABSOLUTE_COVERAGE]; @@ -140,7 +141,7 @@ coverage.updateUi = function(patchStats, patchElement, reportUrl) { * @return {string} Formatted string ready to be added to the the DOM. */ coverage.formatPercent = function(coveragePercent) { - if (typeof coveragePercent === 'undefined') { + if (!coveragePercent) { return '-'; } else { return coveragePercent + '%'; diff --git a/tools/chrome_extensions/chromium_code_coverage/manifest.json b/tools/chrome_extensions/chromium_code_coverage/manifest.json index 34ed514..b8eb440 100644 --- a/tools/chrome_extensions/chromium_code_coverage/manifest.json +++ b/tools/chrome_extensions/chromium_code_coverage/manifest.json @@ -1,6 +1,6 @@ { "manifest_version": 2, - "name": "Chromium Code Coverage", + "name": "Chromium code coverage: deprecated UI", "description": "Adds coverage stats to Rietveld.", "version": "1.0.0", "permissions": [ |