diff options
| author | sdefresne <sdefresne@chromium.org> | 2015-07-18 02:44:54 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-18 09:45:34 +0000 |
| commit | 349423af4f5941a60af567f7bc389ed7dc3da5f9 (patch) | |
| tree | 00f86ff07bc2b6647cd88487feb7916cbe2ce2f2 /tools/clang/plugins | |
| parent | 77e2ee21852429b154493270fcdbe8794bcc1809 (diff) | |
| download | chromium_src-349423af4f5941a60af567f7bc389ed7dc3da5f9.zip chromium_src-349423af4f5941a60af567f7bc389ed7dc3da5f9.tar.gz chromium_src-349423af4f5941a60af567f7bc389ed7dc3da5f9.tar.bz2 | |
Fix chromium clang plugin if run from */Developer/* directory
Do not blacklist directory matching "*/Developer/*" as this is unnecessary
since system headers are already blacklisted by another rule. This allow
developer to checkout Chromium code in $HOME/Developer/chromium (or some
similar path) and still get the Chromium clang warnings and errors.
TEST=Build clang locally as instructed in tools/clang/plugins/README.chromium
and then check that everything builds, then introduce a style error (missing
"override") and check that it is reported by the plugin even if the checkout
path matches "*/Developer/*".
BUG=510886
Review URL: https://codereview.chromium.org/1238153002
Cr-Commit-Position: refs/heads/master@{#339394}
Diffstat (limited to 'tools/clang/plugins')
| -rw-r--r-- | tools/clang/plugins/ChromeClassTester.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp index 6a4233a..af5de10 100644 --- a/tools/clang/plugins/ChromeClassTester.cpp +++ b/tools/clang/plugins/ChromeClassTester.cpp @@ -226,9 +226,6 @@ void ChromeClassTester::BuildBannedLists() { // putting everything in the header. banned_directories_.push_back("/automation/"); - // Don't check system headers. - banned_directories_.push_back("/Developer/"); - // Used in really low level threading code that probably shouldn't be out of // lined. ignored_record_names_.insert("ThreadLocalBoolean"); |