diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-10 19:12:54 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-10 19:12:54 +0000 |
| commit | b4576f34938f6602675117a89f6b5ca0f7b3428a (patch) | |
| tree | 4c25be3a09a0be0329d20454e0ba93edacdff3f2 /tools/clang | |
| parent | c41b93b799416ffaba84a92a688dc2882f2c01f3 (diff) | |
| download | chromium_src-b4576f34938f6602675117a89f6b5ca0f7b3428a.zip chromium_src-b4576f34938f6602675117a89f6b5ca0f7b3428a.tar.gz chromium_src-b4576f34938f6602675117a89f6b5ca0f7b3428a.tar.bz2 | |
Clang plugin: *Overriding* method must have "virtual" keyword.
The overridden method is the one in the base class.
It's the overriding method that might be missing the "virtual" keyword.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8465020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109473 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/clang')
| -rw-r--r-- | tools/clang/plugins/FindBadConstructs.cpp | 2 | ||||
| -rw-r--r-- | tools/clang/plugins/tests/virtual_methods.txt | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tools/clang/plugins/FindBadConstructs.cpp b/tools/clang/plugins/FindBadConstructs.cpp index e79b311..191e413 100644 --- a/tools/clang/plugins/FindBadConstructs.cpp +++ b/tools/clang/plugins/FindBadConstructs.cpp @@ -142,7 +142,7 @@ class FindBadConstructsConsumer : public ChromeClassTester { loc = method->getInnerLocStart(); if (method->isVirtual() && !method->isVirtualAsWritten()) - emitWarning(loc, "Overridden method must have \"virtual\" keyword."); + emitWarning(loc, "Overriding method must have \"virtual\" keyword."); // Virtual methods should not have inline definitions beyond "{}". if (method->isVirtual() && method->hasBody() && method->hasInlineBody()) { diff --git a/tools/clang/plugins/tests/virtual_methods.txt b/tools/clang/plugins/tests/virtual_methods.txt index baa791f..5eb6657 100644 --- a/tools/clang/plugins/tests/virtual_methods.txt +++ b/tools/clang/plugins/tests/virtual_methods.txt @@ -2,7 +2,7 @@ In file included from virtual_methods.cpp:5: ./virtual_methods.h:17:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline. virtual bool ComplainAboutThis() { return true; } ^ -./virtual_methods.h:23:3: warning: [chromium-style] Overridden method must have "virtual" keyword. +./virtual_methods.h:23:3: warning: [chromium-style] Overriding method must have "virtual" keyword. void MethodHasNoArguments(); ^ 2 warnings generated. |