diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 17:58:50 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-30 17:58:50 +0000 |
commit | 33d773aeae720232cc3fa86ab975bb57e0a44793 (patch) | |
tree | a2b38e152861426cda858469c59e373fc17c7646 /tools/clang | |
parent | 321ea19dfb4747fb51308a5ebcb34d7660a8d12e (diff) | |
download | chromium_src-33d773aeae720232cc3fa86ab975bb57e0a44793.zip chromium_src-33d773aeae720232cc3fa86ab975bb57e0a44793.tar.gz chromium_src-33d773aeae720232cc3fa86ab975bb57e0a44793.tar.bz2 |
Remove support code that was used to pin asan to an older revision.
It's no longer needed.
BUG=170629
Review URL: https://codereview.chromium.org/14568002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197404 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/clang')
-rwxr-xr-x | tools/clang/scripts/update.sh | 49 |
1 files changed, 0 insertions, 49 deletions
diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh index dc55555..7471b8a 100755 --- a/tools/clang/scripts/update.sh +++ b/tools/clang/scripts/update.sh @@ -9,8 +9,6 @@ # https://code.google.com/p/chromium/wiki/UpdatingClang # Reverting problematic clang rolls is safe, though. CLANG_REVISION=179138 -# ASan Mac builders are pinned to this revision, see http://crbug.com/170629. -CLANG_ASAN_MAC_REVISION=${CLANG_REVISION} THIS_DIR="$(dirname "${0}")" LLVM_DIR="${THIS_DIR}/../../../third_party/llvm" @@ -36,9 +34,6 @@ mac_only= run_tests= bootstrap= with_android=yes -# Temporary workaround for http://crbug.com/170629: use older Clang for ASan -# Mac builders. -is_asan_mac_builder_hackfix= with_tools_extra= chrome_tools="plugins" @@ -63,11 +58,6 @@ while [[ $# > 0 ]]; do --without-android) with_android= ;; - # Temporary workaround for http://crbug.com/170629 - use older Clang for - # ASan Mac builders. - --is-asan-mac-builder-hackfix) - is_asan_mac_builder_hackfix=yes - ;; --with-tools-extra) with_tools_extra=yes ;; @@ -86,8 +76,6 @@ while [[ $# > 0 ]]; do echo "--mac-only: Do initial download only on Mac systems." echo "--run-tests: Run tests after building. Only for local builds." echo "--without-android: Don't build ASan Android runtime library." - echo "--is-asan-mac-builder-hackfix: Use older Clang" \ - "to build ASan on Mac." echo "--with-tools-extra: Also build the clang-tools-extra repository." echo "--with-chrome-tools: Select which chrome tools to build." \ "Defaults to plugins." @@ -99,43 +87,6 @@ while [[ $# > 0 ]]; do shift done -# Are we on a Chrome buildbot running ASan? -function on_asan_mac_host { - if [[ "${OS}" != "Darwin" ]]; then - return 1 - fi - HOST="$(hostname -s)" - # Old (10.6) Chrome Mac ASan Builder. Kept here till we fully migrate to 10.8 - if [[ "${HOST}" == "vm633-m1" ]]; then - return 0 - fi - # 10.8 Chrome Mac ASan Builder. - if [[ "${HOST}" == "vm672-m1" ]]; then - return 0 - fi - # Chrome Mac ASan LKGR. - if [[ "${HOST}" == "mini11-a1" ]]; then - return 0 - fi - # mac_asan trybots. These share machines with the mac_layout bots, so only - # pin clang if the slave is used for an _asan build, not for a layout build. - if [[ "${PWD}" != *asan* ]]; then - return 1 - fi - for num in {600..655} - do - if [[ "${HOST}" == "vm${num}-m4" ]]; then - return 0 - fi - done - return 1 -} - -# Use older Clang for ASan Mac builds. See http://crbug.com/170629. -if [[ -n "${is_asan_mac_builder_hackfix}" ]] || on_asan_mac_host; then - CLANG_REVISION=${CLANG_ASAN_MAC_REVISION} -fi - # --mac-only prevents the initial download on non-mac systems, but if clang has # already been downloaded in the past, this script keeps it up to date even if # --mac-only is passed in and the system isn't a mac. People who don't like this |