diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-10 22:21:21 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-10 22:21:21 +0000 |
commit | 3c1274df30bbf45d3b7f1f9c3c80c6bc3c9a1178 (patch) | |
tree | e57491086711a04c79c89ef3f69a66eb64000cce /tools/gn/label_unittest.cc | |
parent | efc33dd5cef330f8a867437e25f86405b2351225 (diff) | |
download | chromium_src-3c1274df30bbf45d3b7f1f9c3c80c6bc3c9a1178.zip chromium_src-3c1274df30bbf45d3b7f1f9c3c80c6bc3c9a1178.tar.gz chromium_src-3c1274df30bbf45d3b7f1f9c3c80c6bc3c9a1178.tar.bz2 |
The ldflags are now inherited across module boundaries until a shared library or executable is encountered. This is necessary for the ldflags to actually have any effect in most cases. Since this flag is special there is some minor refactording in Target to make it work.
The GYP command will now request that GYP itself output library dependencies which we'll suck in and use so that libraries inherited up the dependency tree in GYP will also be inherited into the GN portion of the build.
Minor changes to label to make it easier to construct one with no toolchain specified.
I added a helper class for iterating over the config values associated with a target and used it in a number of places. This ensures we always use the same order for walking these.
I did a bunch of work on groups to make it so that if you depend on a group it is like depending directly on that group's deps.
The chrome target will now compile on Linux with GN, using GYP versions of everything else. I added a number of other third_party libraries it needs. There are still some hacks and TODOs in this.
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/23550007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222368 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/gn/label_unittest.cc')
-rw-r--r-- | tools/gn/label_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/gn/label_unittest.cc b/tools/gn/label_unittest.cc index 74eb3da..e4030fe 100644 --- a/tools/gn/label_unittest.cc +++ b/tools/gn/label_unittest.cc @@ -60,8 +60,7 @@ TEST(Label, Resolve) { { "//chrome/", ":bar(t/b)", true, "//chrome/", "bar", "//chrome/t/b/", "b" }, }; - Label default_toolchain(SourceDir("//t/"), "d", - SourceDir(), std::string()); + Label default_toolchain(SourceDir("//t/"), "d"); for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); i++) { const ParseDepStringCase& cur = cases[i]; |