diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 21:09:11 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 21:09:11 +0000 |
| commit | 2c6651d781504b0acecb93fcbff5dc62e0838e46 (patch) | |
| tree | 45ec6de504dd3878334e03ca21ec65e653826ef4 /tools/gritsettings | |
| parent | 07d6ba2d339165c84d2f8b8a0b4b156f1686a84e (diff) | |
| download | chromium_src-2c6651d781504b0acecb93fcbff5dc62e0838e46.zip chromium_src-2c6651d781504b0acecb93fcbff5dc62e0838e46.tar.gz chromium_src-2c6651d781504b0acecb93fcbff5dc62e0838e46.tar.bz2 | |
Revert 282408 "Use upstream libaddressinput in Chrome."
Introduced static initializers into chrome binary:
preload_supplier.cc _GLOBAL__sub_I_preload_supplier.cc+0xa
preload_supplier.cc i18n::addressinput::StringCompare::StringCompare()
preload_supplier.cc __cxa_atexit@plt [registers a dtor to run at exit]
Run ./tools/linux/dump-static-initializers.py before re-landing to
verify they're no longer present.
> Use upstream libaddressinput in Chrome.
>
> Most of the changes are mechanical switches from chromium/ to src/
> directory in third_party/libadressinput/.
>
> To simplify the switch, autofill::AddressValidator is a shim between
> Chromium and i18n::addressinput::AddressValidator. The shim behaves the
> same way as Chromium's version of libaddressinput. The goal is to
> gradually remove the shim and make Chromium work directly with
> libaddressinupt.
>
> Upstream libaddressinput does not include suggestions, which now can be
> found in third_party/libadressinput/chromium/input_suggester.{h,cc}.
>
> A follow up patch will remove Chromium's version of libaddressinput.
>
> BUG=327046
>
> Review URL: https://codereview.chromium.org/298863012
TBR=rouslan@chromium.org
Review URL: https://codereview.chromium.org/388613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282426 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/gritsettings')
| -rw-r--r-- | tools/gritsettings/resource_ids | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/gritsettings/resource_ids b/tools/gritsettings/resource_ids index 675489c..f407798 100644 --- a/tools/gritsettings/resource_ids +++ b/tools/gritsettings/resource_ids @@ -198,6 +198,9 @@ "chrome/browser/resources/sync_file_system_internals_resources.grd": { "includes": [29000], }, + "third_party/libaddressinput/chromium/cpp/res/libaddressinput_strings.grd": { + "messages": [29050], + }, "chrome/app/address_input_strings.grd": { "messages": [29100], }, |