diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-14 18:47:54 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-14 18:47:54 +0000 |
| commit | ccb5c4021fccb00d87e6b3c79b6c3df3cb485a00 (patch) | |
| tree | 153fad1e7bd97e486c735830859e0a37f8611ca3 /tools/heapcheck/PRESUBMIT.py | |
| parent | 3ce597fc42a1cb4914f9e5396708167987e669d7 (diff) | |
| download | chromium_src-ccb5c4021fccb00d87e6b3c79b6c3df3cb485a00.zip chromium_src-ccb5c4021fccb00d87e6b3c79b6c3df3cb485a00.tar.gz chromium_src-ccb5c4021fccb00d87e6b3c79b6c3df3cb485a00.tar.bz2 | |
Add a presubmit check to look for duplicate Valgrind/Heapchecker suppression names.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3343020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/heapcheck/PRESUBMIT.py')
| -rwxr-xr-x | tools/heapcheck/PRESUBMIT.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/heapcheck/PRESUBMIT.py b/tools/heapcheck/PRESUBMIT.py index 415400c..1b47afc 100755 --- a/tools/heapcheck/PRESUBMIT.py +++ b/tools/heapcheck/PRESUBMIT.py @@ -9,6 +9,7 @@ for more details on the presubmit API built into gcl. def CheckChange(input_api, output_api): """Checks the memcheck suppressions files for bad data.""" + suppressions = {} errors = [] skip_next_line = False func_re = input_api.re.compile('[a-z_.]+\(.+\)$') @@ -19,6 +20,13 @@ def CheckChange(input_api, output_api): continue if skip_next_line: + if suppressions.has_key(line): + errors.append('suppression with name "%s" at %s line %s has already ' + 'been defined at line %s' % (line, f.LocalPath(), + line_num, + suppressions[line][1])) + else: + suppressions[line] = (f, line_num) skip_next_line = False continue if line == '{': |