diff options
| author | bryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 23:08:26 +0000 |
|---|---|---|
| committer | bryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-05 23:08:26 +0000 |
| commit | 0cf723585ee607ba7467eb55b74940d52f6d582e (patch) | |
| tree | a6abb0a94b08b58551683936ea5b1fb611e9bcb2 /tools/heapcheck | |
| parent | 39ef434b2a6dfe7ff3ae252a681bc7ccabdaf94f (diff) | |
| download | chromium_src-0cf723585ee607ba7467eb55b74940d52f6d582e.zip chromium_src-0cf723585ee607ba7467eb55b74940d52f6d582e.tar.gz chromium_src-0cf723585ee607ba7467eb55b74940d52f6d582e.tar.bz2 | |
Make PhishingDOMFeatureExtractorTest heapcheck suppressions more specific.
The root cause of these leaks is that the IPC::ChannelProxy is never freed.
This happens because the ChildThread destructor intentionally detaches the
channel from its message loop prior to the channel being destroyed, so the
ChannelProxy's self-reference is not released when the channel closes. In
practice, the leak should only occur just before a renderer is shut down, so
it shouldn't be a problem.
BUG=50598
TEST=tools/heapcheck/chrome_tests.sh -t unit --gtest_filter=PhishingDOM*
Review URL: http://codereview.chromium.org/3035054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55152 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/heapcheck')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index b8d0370..6eb5cc7 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -940,9 +940,19 @@ fun:sync_notifier::::ChromeSystemResourcesTest::ScheduleShouldNotRun } { - bug_50598 + bug_50598_a Heapcheck:Leak ... + fun:RenderThread + fun:safe_browsing::PhishingDOMFeatureExtractorTest::SetUp +} +{ + bug_50598_b + Heapcheck:Leak + fun:WaitableEvent + fun:ChildProcess + fun:RenderProcess + fun:MockRenderProcess fun:safe_browsing::PhishingDOMFeatureExtractorTest::SetUp } { |