diff options
| author | mfoltz@chromium.org <mfoltz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-09 09:51:38 +0000 |
|---|---|---|
| committer | mfoltz@chromium.org <mfoltz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-09 09:51:38 +0000 |
| commit | ce071ad7740bc78d118e5d99d9e3113709c72407 (patch) | |
| tree | 9df39990dd57297d26432129e35c2b9cdf6ce44a /tools/heapcheck | |
| parent | d701071128d3e2dc1c8521de3acc5d81e0a8d447 (diff) | |
| download | chromium_src-ce071ad7740bc78d118e5d99d9e3113709c72407.zip chromium_src-ce071ad7740bc78d118e5d99d9e3113709c72407.tar.gz chromium_src-ce071ad7740bc78d118e5d99d9e3113709c72407.tar.bz2 | |
Multiple memory leak fixes in unittest.
- Simplify Close() to always tear down the underlying socket
- Always close the TestCastSocket in TearDown()
- Keep track of whether the mock socket was actually passed to CastSocket and destroy it if necessary
- Fix virtual dtor
TESTED=$ASAN_OPTIONS="detect_leaks=1 strict_memcmp=0" out/{Debug,Release}/unit_tests --gtest_filter="CastSocket*"
BUG=304970
Review URL: https://codereview.chromium.org/26358004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227709 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/heapcheck')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 4bb02ec..fbdb16e 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -852,10 +852,3 @@ fun:chromeos::KeyboardDrivenEventRewriterTest::GetRewrittenEventAsString fun:chromeos::KeyboardDrivenEventRewriterTest_PassThrough_Test::TestBody } -{ - bug_304970 - Heapcheck:Leak - ... - fun:TestCastSocket - fun:extensions::api::cast_channel::CastSocketTest::SetUp -} |