summaryrefslogtreecommitdiffstats
path: root/tools/heapcheck
diff options
context:
space:
mode:
authorvrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-26 00:12:38 +0000
committervrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-26 00:12:38 +0000
commit2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9 (patch)
treed3223ba6aa7a9c6e75de2c2992ca0eb8c73f9f4c /tools/heapcheck
parentcb592c2a727cb7e9609a4b5dccf4e719ab120088 (diff)
downloadchromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.zip
chromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.tar.gz
chromium_src-2c3df19adeb8872a1cc1a9e779be9cd15c55bdc9.tar.bz2
Fixes ReadInternal() memory leak from BufferedDataSource tests
Makes Read() calls from the loader class automatically delete the given ReadCallback by default, so as to prevent memory leaks when a test does not explicitly delete the ReadCallback. Also deletes valgrind and heapcheck suppressions associated with this fix. BUG=60381 TEST=test_shell_tests Review URL: http://codereview.chromium.org/4116001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63817 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/heapcheck')
-rw-r--r--tools/heapcheck/suppressions.txt10
1 files changed, 0 insertions, 10 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt
index d9d58f9..7e1ae4d 100644
--- a/tools/heapcheck/suppressions.txt
+++ b/tools/heapcheck/suppressions.txt
@@ -1109,13 +1109,3 @@
fun:main
fun:__libc_start_main
}
-{
- bug_60381
- Heapcheck:Leak
- fun:Callback1::Type* NewCallback
- fun:webkit_glue::BufferedDataSource::ReadInternal
- fun:webkit_glue::BufferedDataSource::ReadTask
- fun:void DispatchToMethod
- fun:RunnableMethod::Run
- fun:MessageLoop::RunTask
-}