diff options
| author | zea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-23 21:59:00 +0000 |
|---|---|---|
| committer | zea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-23 21:59:00 +0000 |
| commit | 0677c6951f4458c6b56484e9a0fc074466761dc8 (patch) | |
| tree | 89e9df8281fb6a40d70f61a2abffd558bfa36ea9 /tools/heapcheck | |
| parent | ef31c68d5fa6fdd04ff9a794a8064e566038a160 (diff) | |
| download | chromium_src-0677c6951f4458c6b56484e9a0fc074466761dc8.zip chromium_src-0677c6951f4458c6b56484e9a0fc074466761dc8.tar.gz chromium_src-0677c6951f4458c6b56484e9a0fc074466761dc8.tar.bz2 | |
[Sync] Have SyncableService's take ownership of their SyncChangeProcessor.
The UIDataTypeController now uses a SharedChangeProcessor, and passes a ref
to the SyncableService's. Every SyncableService now owns its own change
processor. Additionally, we use the ScopedPtr::Pass semantics for passing
around SyncChangeProcessors to ensure SyncableServices properly take
ownership.
This, along with all the test updates it requires (most of the patch) fixes
several leaks introduced in the previous patch to remove the Syncable Service
Adapter. SyncableServiceMock is removed as it didn't play nice with
scoped_ptr parameters (and was hardly used).
BUG=117098,117538
TEST=unit_tests with valgrind/drmemory/heapcheck
TBR=georgy@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9749012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128578 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/heapcheck')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 903ae26b..ed6fd8c 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1766,40 +1766,6 @@ fun:chromeos::DesktopNotificationsTest::SetUp } { - bug_117098_a - Heapcheck:Leak - fun:base::internal::WeakReferenceOwner::GetRef - fun:base::SupportsWeakPtr::AsWeakPtr - fun:ProfileSyncServicePreferenceTest::StartSyncService -} -{ - bug_117098_b - Heapcheck:Leak - fun:__gnu_cxx::new_allocator::allocate - fun:std::_Vector_base::_M_allocate - fun:std::vector::_M_insert_aux - fun:std::vector::push_back - fun:browser_sync::GenericChangeProcessor::ApplyChangesFromSyncModel -} -{ - bug_117098_c - Heapcheck:Leak - fun:CreateAndSaveChangeProcessorActionP::gmock_Impl::gmock_PerformImpl - fun:testing::internal::ActionHelper::Perform - fun:CreateAndSaveChangeProcessorActionP::gmock_Impl::Perform - fun:testing::Action::Perform - fun:testing::internal::ActionResultHolder::PerformAction - fun:testing::internal::FunctionMockerBase::UntypedPerformAction - fun:testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith - fun:testing::internal::FunctionMockerBase::InvokeWith - fun:testing::internal::FunctionMocker::Invoke - fun:ProfileSyncComponentsFactoryMock::CreateGenericChangeProcessor - fun:browser_sync::UIDataTypeController::Associate - fun:browser_sync::UIDataTypeController::Start - fun:browser_sync::DataTypeManagerImpl::StartNextType - fun:browser_sync::DataTypeManagerImpl::DownloadReady -} -{ bug_117389 Heapcheck:Leak ... |