diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 23:49:55 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 23:49:55 +0000 |
| commit | 2d72cfee8e161d0511516c43bf34664ecf0046d8 (patch) | |
| tree | 7c0cb50addaa5f26fbf01e328c2260d02931aa2d /tools/nocompile_driver.py | |
| parent | b704789c4be9893476f87212551b7ed85f20df4c (diff) | |
| download | chromium_src-2d72cfee8e161d0511516c43bf34664ecf0046d8.zip chromium_src-2d72cfee8e161d0511516c43bf34664ecf0046d8.tar.gz chromium_src-2d72cfee8e161d0511516c43bf34664ecf0046d8.tar.bz2 | |
Fix no-compile tests in base.
- Fixed a nocompile test wasn't ever no compiled (probably a side effect
of http://crrev.com/111889) and never worked.
- Updated the error messages to those used by gcc 4.6 in Precise
- Minor improvement to the nocompile driver that makes the compiler
output more friendly when the regex includes a single quote. Hopefully
no one needs to match a double quote for awhile...
TBR=darin
Review URL: https://codereview.chromium.org/12040055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/nocompile_driver.py')
| -rwxr-xr-x | tools/nocompile_driver.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tools/nocompile_driver.py b/tools/nocompile_driver.py index ca71127..5a8a081 100755 --- a/tools/nocompile_driver.py +++ b/tools/nocompile_driver.py @@ -273,17 +273,17 @@ def FailTest(resultfile, test, error, stdout=None, stderr=None): stdout: The test's output to stdout. stderr: The test's output to stderr. """ - resultfile.write('#error %s Failed: %s\n' % (test['name'], error)) - resultfile.write('#error compile line: %s\n' % test['cmdline']) + resultfile.write('#error "%s Failed: %s"\n' % (test['name'], error)) + resultfile.write('#error "compile line: %s"\n' % test['cmdline']) if stdout and len(stdout) != 0: - resultfile.write('#error %s stdout:\n' % test['name']) + resultfile.write('#error "%s stdout:"\n' % test['name']) for line in stdout.split('\n'): - resultfile.write('#error %s\n' % line) + resultfile.write('#error " %s:"\n' % line) if stderr and len(stderr) != 0: - resultfile.write('#error %s stderr:\n' % test['name']) + resultfile.write('#error "%s stderr:"\n' % test['name']) for line in stderr.split('\n'): - resultfile.write('#error %s\n' % line) + resultfile.write('#error " %s"\n' % line) resultfile.write('\n') |