diff options
| author | dsinclair <dsinclair@chromium.org> | 2014-09-15 11:03:49 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-15 18:18:01 +0000 |
| commit | 19ec9dafd5f465da381974c78a670b0e5fb15d22 (patch) | |
| tree | 29cae979bd8696b983ec3964bc4695b7f3f0bc00 /tools/perf/benchmarks/indexeddb_perf.py | |
| parent | d7a19f0266b5f7e9b96630d67d136ec7dd150825 (diff) | |
| download | chromium_src-19ec9dafd5f465da381974c78a670b0e5fb15d22.zip chromium_src-19ec9dafd5f465da381974c78a670b0e5fb15d22.tar.gz chromium_src-19ec9dafd5f465da381974c78a670b0e5fb15d22.tar.bz2 | |
Revert of Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/562243004/)
Reason for revert:
Reverting the revert. Bot still failed with this CL reverted. Sorry for the noise.
Original issue's description:
> Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/554583003/)
>
> Reason for revert:
> It looks like the moto E perf bots are broken. This change looks like it makes sense so I'm reverting.
>
> crbug.com/414267
>
> Original issue's description:
> > Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.
> >
> > BUG=413481
> >
> > Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6
> > Cr-Commit-Position: refs/heads/master@{#294703}
>
> TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=413481
>
> Committed: https://crrev.com/5f712b7be45145522f183d683f11bfb243dd89e1
> Cr-Commit-Position: refs/heads/master@{#294816}
TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com
NOTREECHECKS=true
NOTRY=true
BUG=413481
Review URL: https://codereview.chromium.org/569333002
Cr-Commit-Position: refs/heads/master@{#294850}
Diffstat (limited to 'tools/perf/benchmarks/indexeddb_perf.py')
| -rw-r--r-- | tools/perf/benchmarks/indexeddb_perf.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/benchmarks/indexeddb_perf.py b/tools/perf/benchmarks/indexeddb_perf.py index 3bc8cc8..8db9e54 100644 --- a/tools/perf/benchmarks/indexeddb_perf.py +++ b/tools/perf/benchmarks/indexeddb_perf.py @@ -42,9 +42,9 @@ class _IndexedDbMeasurement(page_test.PageTest): self._power_metric = None self._v8_object_stats_metric = None - def WillStartBrowser(self, browser): + def WillStartBrowser(self, platform): """Initialize metrics once right before the browser has been launched.""" - self._power_metric = power.PowerMetric(browser) + self._power_metric = power.PowerMetric(platform) def DidStartBrowser(self, browser): """Initialize metrics once right after the browser has been launched.""" |