diff options
| author | samuong <samuong@chromium.org> | 2015-05-27 15:13:49 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-27 22:14:13 +0000 |
| commit | fb9823b0bd5819345dcb105740e765e34f2e09f8 (patch) | |
| tree | 38845c9466b96582529a9499e6b5e9f930dba35e /tools/perf | |
| parent | a2d45701cb21244b9514e420950ba6ba687fb655 (diff) | |
| download | chromium_src-fb9823b0bd5819345dcb105740e765e34f2e09f8.zip chromium_src-fb9823b0bd5819345dcb105740e765e34f2e09f8.tar.gz chromium_src-fb9823b0bd5819345dcb105740e765e34f2e09f8.tar.bz2 | |
Revert of Make sure that tracing is always cleaned up for v8_gc_times page_test (patchset #4 id:60001 of https://codereview.chromium.org/1151933005/)
Reason for revert:
I suspect this is causing failures on telemetry_perf_unittests - see https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29 build #37836 and later
Original issue's description:
> Make sure that tracing is always cleaned up for v8_gc_times page_test
>
> BUG=491104
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/1d1d10c687de9424db5a66a89d179f11784d7ee8
> Cr-Commit-Position: refs/heads/master@{#331590}
TBR=sullivan@chromium.org,rmcilroy@chromium.org,prasadv@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=491104
Review URL: https://codereview.chromium.org/1147093008
Cr-Commit-Position: refs/heads/master@{#331669}
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/measurements/v8_gc_times.py | 4 | ||||
| -rw-r--r-- | tools/perf/measurements/v8_gc_times_unittest.py | 3 |
2 files changed, 0 insertions, 7 deletions
diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py index c964902..01e2d01 100644 --- a/tools/perf/measurements/v8_gc_times.py +++ b/tools/perf/measurements/v8_gc_times.py @@ -42,10 +42,6 @@ class V8GCTimes(page_test.PageTest): renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id) self._AddV8MetricsToResults(renderer_process, results) - def CleanUpAfterPage(self, page, tab): - if tab.browser.platform.tracing_controller.is_tracing_running: - tab.browser.platform.tracing_controller.Stop() - def _AddV8MetricsToResults(self, process, results): if process is None: return diff --git a/tools/perf/measurements/v8_gc_times_unittest.py b/tools/perf/measurements/v8_gc_times_unittest.py index 3ee121c..aaf816b 100644 --- a/tools/perf/measurements/v8_gc_times_unittest.py +++ b/tools/perf/measurements/v8_gc_times_unittest.py @@ -238,9 +238,6 @@ class V8GCTimesTests(page_test_test_case.PageTestTestCase): 'Result for [' + key + '] - expected ' + str(expected[key]) + ' but got ' + str(actual[key])) - def testCleanUpTrace(self): - self.TestTracingCleanedUp(v8_gc_times.V8GCTimes, self._options) - def _ActualValues(results): return dict(list( |