diff options
| author | fmeawad@chromium.org <fmeawad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-18 23:02:43 +0000 |
|---|---|---|
| committer | fmeawad@chromium.org <fmeawad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-18 23:02:43 +0000 |
| commit | fda5a922d9e1223ca915ab85fd8f4e16329f0776 (patch) | |
| tree | 54d1c56d2a5fd65d6754d70a9ff7471da5fa939e /tools/perf | |
| parent | 2d3593c84ddc00bc7946e0ff2757471ef07762cf (diff) | |
| download | chromium_src-fda5a922d9e1223ca915ab85fd8f4e16329f0776.zip chromium_src-fda5a922d9e1223ca915ab85fd8f4e16329f0776.tar.gz chromium_src-fda5a922d9e1223ca915ab85fd8f4e16329f0776.tar.bz2 | |
[Telemetry] Change the default cold-load-percent for all page_cyclers to 50%
To PERF SHERIFFS,
This CL will result in a change in the cold and warm ranges reported by the page cyclers. As we move to a balanced load, cold page loads will be less noisy but might jump to a slightly lower range, while warm page loads should stay the same (might get a little noisier).
BUG=
Review URL: https://codereview.chromium.org/202023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257799 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/benchmarks/page_cycler.py | 3 | ||||
| -rw-r--r-- | tools/perf/measurements/page_cycler.py | 2 | ||||
| -rw-r--r-- | tools/perf/measurements/page_cycler_unittest.py | 6 |
3 files changed, 5 insertions, 6 deletions
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py index 1bcbf3d..7c930d9 100644 --- a/tools/perf/benchmarks/page_cycler.py +++ b/tools/perf/benchmarks/page_cycler.py @@ -52,8 +52,7 @@ class PageCyclerIntlKoThVi(test.Test): class PageCyclerMorejs(test.Test): test = page_cycler.PageCycler page_set = 'page_sets/page_cycler/morejs.json' - options = {'pageset_repeat_iters': 20, - 'cold_load_percent': 50} + options = {'pageset_repeat_iters': 10} class PageCyclerMoz(test.Test): diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py index 498cd5d..c5d8b62 100644 --- a/tools/perf/measurements/page_cycler.py +++ b/tools/perf/measurements/page_cycler.py @@ -57,7 +57,7 @@ class PageCycler(page_measurement.PageMeasurement): action='store_true', help='Enable the speed index metric.') - parser.add_option('--cold-load-percent', type='int', + parser.add_option('--cold-load-percent', type='int', default=50, help='%d of page visits for which a cold load is forced') @classmethod diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py index be6c6ac..0cc0efd 100644 --- a/tools/perf/measurements/page_cycler_unittest.py +++ b/tools/perf/measurements/page_cycler_unittest.py @@ -100,12 +100,12 @@ class PageCyclerUnitTest(unittest.TestCase): def testOptionsColdLoadNoArgs(self): cycler = self.SetUpCycler([]) - self.assertEquals(cycler._cold_run_start_index, 10) + self.assertEquals(cycler._cold_run_start_index, 5) def testOptionsColdLoadPagesetRepeat(self): cycler = self.SetUpCycler(['--pageset-repeat=20', '--page-repeat=2']) - self.assertEquals(cycler._cold_run_start_index, 40) + self.assertEquals(cycler._cold_run_start_index, 20) def testOptionsColdLoadRequested(self): cycler = self.SetUpCycler(['--pageset-repeat=21', '--page-repeat=2', @@ -172,7 +172,7 @@ class PageCyclerUnitTest(unittest.TestCase): self.assertEqual(1, len(values)) self.assertEqual(values[0].page, page) - chart_name = 'cold_times' if i == 0 else 'warm_times' + chart_name = 'cold_times' if i == 0 or i > 1 else 'warm_times' self.assertEqual(values[0].name, '%s.page_load_time' % chart_name) cycler.DidNavigateToPage(page, tab) |