diff options
| author | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-09 02:35:19 +0000 |
|---|---|---|
| committer | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-09 02:35:19 +0000 |
| commit | 3751593896aec722a8f0ad6014cbc2c67a9e78d9 (patch) | |
| tree | b5e349c18d18785911576a042846a75b0e136e30 /tools/perf_expectations/PRESUBMIT.py | |
| parent | db96a88617afc0e619c06234bd4f4670ccfe1ae3 (diff) | |
| download | chromium_src-3751593896aec722a8f0ad6014cbc2c67a9e78d9.zip chromium_src-3751593896aec722a8f0ad6014cbc2c67a9e78d9.tar.gz chromium_src-3751593896aec722a8f0ad6014cbc2c67a9e78d9.tar.bz2 | |
make_expectations verifications for expectations.
In make_expectations.py, add -s argument which verifies
that all of the expectations are up-to-date and that
running make_expectations would not update any keys.
Support loading the config file based on the path
to the expectations script, this allows running
make_expectations.py from outside the perf_expectations
directory.
In the presubmit tests on commit, always check whether
the change can be submitted. Add a presubmit test
that runs make_expectations.py -s to verify no updates
are pending.
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/8212004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104667 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/perf_expectations/PRESUBMIT.py')
| -rw-r--r-- | tools/perf_expectations/PRESUBMIT.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/perf_expectations/PRESUBMIT.py b/tools/perf_expectations/PRESUBMIT.py index 9dd408f..5897b3a 100644 --- a/tools/perf_expectations/PRESUBMIT.py +++ b/tools/perf_expectations/PRESUBMIT.py @@ -41,6 +41,7 @@ def CheckChangeOnCommit(input_api, output_api): output.extend(input_api.canned_checks.RunPythonUnitTests(input_api, output_api, UNIT_TESTS)) - output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api, - output_api)) + + output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api, + output_api)) return output |