Remove initial_sync_ended bits

As of crbug.com/164288, we can no longer trust initial_sync_ended.  If
my diagnosis is correct, then there are some clients out there who have
their initial_sync_ended bits set for some data types which have not
actually been synced.  Those clients now crash at every startup.

This change attempts to solve the problem by removing the separate
initial_sync_ended array of bools and checking the database directly to
learn of a type's status.  The new definition of initial_sync_ended is
that a type has finished initial sync if its top level folder has been
downloaded and applied.

To prevent crashing if the server decides to not send us those root
nodes during the control types configure step, we now check that all
control types are initial_sync_ended following that configure and fail
gracefully if their initial sync is not completed.

The new definition of initial_sync_ended makes it much easier to hit
crbug.com/164914.  That bug would prevent us from saving our changes
following a call to PurgeEntriesWithTypeIn() in some situations.  This
commit also fixes that bug.

Since the initial sync ended status is no longer independent from the
database state, it is no longer necessary to collect debug info as to
its status.  It has been removed from the about:sync UI and other debug
info reporting mechanisms.  Its role in unit tests has also been greatly
reduced.

BUG=164288,164914

Review URL: https://chromiumcodereview.appspot.com/11474036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172707 0039d316-1c4b-4281-b951-d872f2087c98

0 files changed, 0 insertions, 0 deletions