summaryrefslogtreecommitdiffstats
path: root/tools/perf_expectations/tests
diff options
context:
space:
mode:
authordominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-17 19:06:55 +0000
committerdominich@chromium.org <dominich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-17 19:06:55 +0000
commitfa9c3cb5a1f4fb2bca65c42c517765a4415e6f0e (patch)
treeae0ca8cfa7f449f755fa8ad754d7ca3f9c50b65c /tools/perf_expectations/tests
parent8e6ac4b00fb9378b2cf61b83e262970de18bef2c (diff)
downloadchromium_src-fa9c3cb5a1f4fb2bca65c42c517765a4415e6f0e.zip
chromium_src-fa9c3cb5a1f4fb2bca65c42c517765a4415e6f0e.tar.gz
chromium_src-fa9c3cb5a1f4fb2bca65c42c517765a4415e6f0e.tar.bz2
Wait for the make_expectations.py process to finish before checking return code.
BUG=None TEST=perf_expectations_unittest.py should succeed if no expectations are waiting for updates. TBR=cmp@chromium.org Review URL: http://codereview.chromium.org/8318022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105870 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/perf_expectations/tests')
-rwxr-xr-xtools/perf_expectations/tests/perf_expectations_unittest.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf_expectations/tests/perf_expectations_unittest.py b/tools/perf_expectations/tests/perf_expectations_unittest.py
index d2b8fc4..92d4308 100755
--- a/tools/perf_expectations/tests/perf_expectations_unittest.py
+++ b/tools/perf_expectations/tests/perf_expectations_unittest.py
@@ -150,6 +150,7 @@ class PerfExpectationsUnittest(unittest.TestCase):
def testNoUpdatesNeeded(self):
p = subprocess.Popen([MAKE_EXPECTATIONS, '-s'], stdout=subprocess.PIPE)
+ p.wait();
self.assertEqual(p.returncode, 0, msg='Expectations has pending updates!')
def testConfigFile(self):