Add more sizes checks.

Review URL: http://codereview.chromium.org/7304001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91404 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 23 insertions, 2 deletions

diff --git a/tools/perf_expectations/make_expectations.py b/tools/perf_expectations/make_expectations.py
index fc7f46f..bd6018a 100755
--- a/tools/perf_expectations/make_expectations.py
+++ b/tools/perf_expectations/make_expectations.py
@@ -273,8 +273,14 @@ def Main(args):
       improve = int(math.floor(improve - abs(improve*variance)))
       regress = int(math.ceil(regress + abs(regress*variance)))
 
+    # Calculate the new checksum to test if this is the only thing that may have
+    # changed.
+    checksum_rowdata = GetRowData(perf, key)
+    new_checksum = GetRowDigest(checksum_rowdata, key)
+
     if ('regress' in perf[key] and 'improve' in perf[key] and
-        perf[key]['regress'] == regress and perf[key]['improve'] == improve):
+        perf[key]['regress'] == regress and perf[key]['improve'] == improve and
+        original_checksum == new_checksum):
       OutputMessage('no change')
       continue
 
diff --git a/tools/perf_expectations/perf_expectations.json b/tools/perf_expectations/perf_expectations.json
index 72bb98a..fc0e651 100644
--- a/tools/perf_expectations/perf_expectations.json
+++ b/tools/perf_expectations/perf_expectations.json
@@ -1,4 +1,10 @@
-{"linux-release-hardy/dhtml/commit_charge/cc": {"reva": 63231, "revb": 64325, "improve": -6947, "regress": 25528, "sha1": "0e22e67a"},
+{"linux-release-64/sizes/chrome-bss/bss": {"reva": 91085, "revb": 91326, "type": "absolute", "improve": 565495, "regress": 625223, "sha1": "eac0d7ac"},
+ "linux-release-64/sizes/chrome-data/data": {"reva": 91119, "revb": 91326, "type": "absolute", "improve": 2309480, "regress": 2557742, "sha1": "fd84a9d2"},
+ "linux-release-64/sizes/chrome-si/initializers": {"reva": 90971, "revb": 91326, "type": "absolute", "improve": 389, "regress": 431, "sha1": "f1eefcfd"},
+ "linux-release-64/sizes/chrome-text/text": {"reva": 91010, "revb": 91326, "type": "absolute", "improve": 58265824, "regress": 64542416, "sha1": "e45ea3d9"},
+ "linux-release-64/sizes/chrome.pak/chrome.pak": {"reva": 91189, "revb": 91326, "type": "absolute", "improve": 2763256, "regress": 3054155, "sha1": "128e339e"},
+ "linux-release-64/sizes/chrome/chrome": {"reva": 91177, "revb": 91321, "type": "absolute", "improve": 75401522, "regress": 83416007, "sha1": "98a0048f"},
+ "linux-release-hardy/dhtml/commit_charge/cc": {"reva": 63231, "revb": 64325, "improve": -6947, "regress": 25528, "sha1": "0e22e67a"},
  "linux-release-hardy/dhtml/processes/proc_": {"improve": 0, "regress": 0, "sha1": "696fcb0f"},
  "linux-release-hardy/dhtml/times/t": {"reva": 87778, "revb": 88209, "improve": -68, "regress": 21, "sha1": "805a1511"},
  "linux-release-hardy/dhtml/total_byte_b/IO_b": {"reva": 85983, "revb": 88209, "improve": 4132, "regress": 6013, "sha1": "b7cb3bfb"},
@@ -39,6 +45,12 @@
  "linux-release/intl2/times/t": {"improve": -18, "regress": 12, "sha1": "27778034"},
  "linux-release/morejs/times/t": {"improve": 100, "regress": 130, "sha1": "6cb7d2e8"},
  "linux-release/moz/times/t": {"improve": -15, "regress": 15, "sha1": "6e690f60"},
+ "linux-release/sizes/chrome-bss/bss": {"reva": 91085, "revb": 91326, "type": "absolute", "improve": 328321, "regress": 362950, "sha1": "6718b4cc"},
+ "linux-release/sizes/chrome-data/data": {"reva": 91119, "revb": 91326, "type": "absolute", "improve": 1134619, "regress": 1257002, "sha1": "3fcf972c"},
+ "linux-release/sizes/chrome-si/initializers": {"reva": 90971, "revb": 91326, "type": "absolute", "improve": 392, "regress": 434, "sha1": "3f96304c"},
+ "linux-release/sizes/chrome-text/text": {"reva": 91010, "revb": 91326, "type": "absolute", "improve": 50924512, "regress": 56409963, "sha1": "c6eabdc8"},
+ "linux-release/sizes/chrome.pak/chrome.pak": {"reva": 91189, "revb": 91326, "type": "absolute", "improve": 2763256, "regress": 3054155, "sha1": "786464bf"},
+ "linux-release/sizes/chrome/chrome": {"reva": 91177, "revb": 91321, "type": "absolute", "improve": 65341452, "regress": 72282009, "sha1": "d05e65ea"},
  "linux-release/startup/times/t": {"improve": -15, "regress": 15, "sha1": "c8f06f81"},
  "mac-release-10.5/dhtml/times/t": {"improve": -90, "regress": 90, "sha1": "63a69fd0"},
  "mac-release-10.5/intl1/times/t": {"reva": 80750, "revb": 81318, "improve": -340, "regress": 120, "sha1": "03456e1f"},
@@ -62,6 +74,9 @@
  "mac-release-10.6/moz/times/t": {"reva": 68096, "revb": 69048, "improve": -3314, "regress": 2668, "sha1": "fe58113c"},
  "mac-release-10.6/startup/times/t": {"improve": -2, "regress": 22, "sha1": "132f6c77"},
  "mac-release-10.6/v8_benchmark/score/score": {"reva": 68707, "revb": 69073, "improve": 1018, "regress": -719, "sha1": "18036dcf"},
+ "mac-release/sizes/Chromium.app/Chromium.app": {"reva": 91265, "revb": 91310, "type": "absolute", "improve": 87369113, "regress": 96699188, "sha1": "e1eac8fc"},
+ "mac-release/sizes/Chromium/Chromium": {"reva": 91247, "revb": 91310, "type": "absolute", "improve": 12182, "regress": 13466, "sha1": "c12da234"},
+ "mac-release/sizes/ChromiumFramework/ChromiumFramework": {"reva": 90999, "revb": 91310, "type": "absolute", "improve": 57344937, "regress": 63464390, "sha1": "82a40879"},
  "vista-release-dual-core/dhtml/times/t": {"reva": 76712, "revb": 77859, "improve": -22, "regress": 255, "sha1": "c691ad5a"},
  "vista-release-dual-core/intl1/times/t": {"reva": 68696, "revb": 69048, "improve": -361, "regress": 1064, "sha1": "523889d9"},
  "vista-release-dual-core/intl2/times/t": {"improve": -180, "regress": 215, "sha1": "5ed79b52"},