summaryrefslogtreecommitdiffstats
path: root/tools/perf_expectations
diff options
context:
space:
mode:
authorqyearsley <qyearsley@chromium.org>2015-06-04 16:58:18 -0700
committerCommit bot <commit-bot@chromium.org>2015-06-04 23:59:48 +0000
commit8a514644310cd68174ada42bb1e6da1a6b1a88e5 (patch)
treea9c37b926168dcbe53268c06da95ce50d79dbfb1 /tools/perf_expectations
parent9960617805936cad72f37cd12b5264a7fc40af91 (diff)
downloadchromium_src-8a514644310cd68174ada42bb1e6da1a6b1a88e5.zip
chromium_src-8a514644310cd68174ada42bb1e6da1a6b1a88e5.tar.gz
chromium_src-8a514644310cd68174ada42bb1e6da1a6b1a88e5.tar.bz2
In make_expectations, ignore "rev" if cannot be parsed as an int.
BUG=492505 Review URL: https://codereview.chromium.org/1153333002 Cr-Commit-Position: refs/heads/master@{#332967}
Diffstat (limited to 'tools/perf_expectations')
-rwxr-xr-xtools/perf_expectations/make_expectations.py13
1 files changed, 7 insertions, 6 deletions
diff --git a/tools/perf_expectations/make_expectations.py b/tools/perf_expectations/make_expectations.py
index 0aca7a0..b8c35a9 100755
--- a/tools/perf_expectations/make_expectations.py
+++ b/tools/perf_expectations/make_expectations.py
@@ -241,14 +241,15 @@ def Main(args):
scanning = False
for line in summarylist:
jsondata = ConvertJsonIntoDict(line)
-
- # TODO(iannucci): Remove this once http://crbug.com/336471 is resolved.
- if 'Force the Chro' in jsondata['rev']:
+ try:
+ rev = int(jsondata['rev'])
+ except ValueError:
+ print ('Warning: skipping rev %r because could not be parsed '
+ 'as an integer.' % jsondata['rev'])
continue
-
- if int(jsondata['rev']) <= revb:
+ if rev <= revb:
scanning = True
- if int(jsondata['rev']) < reva:
+ if rev < reva:
break
# We found the upper revision in the range. Scan for trace data until we