diff options
| author | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-13 20:00:12 +0000 |
|---|---|---|
| committer | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-13 20:00:12 +0000 |
| commit | 7c450ecef217d23fe26a95ce63e938113cf8812d (patch) | |
| tree | 8400476620a66f6891818dcd9dee799309d0d7b0 /tools/telemetry | |
| parent | 247cf060ceed2496e999fc4c0099d0c36f8e4745 (diff) | |
| download | chromium_src-7c450ecef217d23fe26a95ce63e938113cf8812d.zip chromium_src-7c450ecef217d23fe26a95ce63e938113cf8812d.tar.gz chromium_src-7c450ecef217d23fe26a95ce63e938113cf8812d.tar.bz2 | |
Telemetry: More elegant histogram printing.
We now consider the _by_url data important for histograms, and only print out
histograms one by one. So we don't need hacks in perf_tests_helper for printing
out a list of histograms (for which we don't any more know which page they refer to).
BUG=158323
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172939 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/telemetry')
| -rw-r--r-- | tools/telemetry/telemetry/multi_page_benchmark.py | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/tools/telemetry/telemetry/multi_page_benchmark.py b/tools/telemetry/telemetry/multi_page_benchmark.py index 4d051dc..3a8b734 100644 --- a/tools/telemetry/telemetry/multi_page_benchmark.py +++ b/tools/telemetry/telemetry/multi_page_benchmark.py @@ -81,9 +81,11 @@ results! You must return the same dict keys every time.""" self.results_summary.iteritems()): measurement, units, data_type = measurement_units_type if data_type == 'histogram': - unimportant_data_type = 'unimportant-histogram' + # For histograms, the _by_url data is important. + by_url_data_type = 'histogram' else: - unimportant_data_type = 'unimportant' + # For non-histograms, the _by_url data is unimportant. + by_url_data_type = 'unimportant' if '.' in measurement: measurement, trace = measurement.split('.', 1) trace += (trace_tag or '') @@ -94,8 +96,10 @@ results! You must return the same dict keys every time.""" assert len(self.urls) == len(values) for i, value in enumerate(values): PrintPerfResult(measurement + '_by_url', self.urls[i], [value], units, - unimportant_data_type) - PrintPerfResult(measurement, trace, values, units, data_type) + by_url_data_type) + # For histograms, we don't print the average data, only the _by_url. + if not data_type == 'histogram': + PrintPerfResult(measurement, trace, values, units, data_type) class IncrementalBenchmarkResults(BenchmarkResults): |