diff options
| author | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-21 21:07:53 +0000 |
|---|---|---|
| committer | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-21 21:07:53 +0000 |
| commit | 77c2af208b64e6b8c128efe79c05932d63d33571 (patch) | |
| tree | 4490018633dd3753fd79bdc9b38babe97bf33ad6 /tools/valgrind/chrome_tests.py | |
| parent | 9db1d46d0d31b0aea57099f55f4566404d2e0fd3 (diff) | |
| download | chromium_src-77c2af208b64e6b8c128efe79c05932d63d33571.zip chromium_src-77c2af208b64e6b8c128efe79c05932d63d33571.tar.gz chromium_src-77c2af208b64e6b8c128efe79c05932d63d33571.tar.bz2 | |
Try change 23924 again - refactor layout_package.path_utils and
layout_package.platform_utils.
Deltas from that change:
* Don't enable 'win-xp' as the default platform
* Don't assume 'webkit/Release' exists (it doesn't by default on mac and
linux), and fix the output results directory path in run_webkit_tests
* Update tools/valgrind/chrome_tests.py (which I didn't realize
depended on the layout_package code).
BUG=none
R=tony@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24007 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/chrome_tests.py')
| -rwxr-xr-x | tools/valgrind/chrome_tests.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.py index d508e0a..af0ad29 100755 --- a/tools/valgrind/chrome_tests.py +++ b/tools/valgrind/chrome_tests.py @@ -28,7 +28,7 @@ import google.path_utils # TODO(erg): Copy/Move the relevant functions from the layout_package version # of platform_utils back up to google.platform_utils # package. http://crbug.com/6164 -import layout_package.platform_utils +import layout_package.path_utils import common import valgrind_test @@ -100,14 +100,14 @@ class ChromeTests: self._test = test script_dir = google.path_utils.ScriptDir() - utility = layout_package.platform_utils.PlatformUtility(script_dir) # Compute the top of the tree (the "source dir") from the script dir (where # this script lives). We assume that the script dir is in tools/valgrind/ # relative to the top of the tree. self._source_dir = os.path.dirname(os.path.dirname(script_dir)) # since this path is used for string matching, make sure it's always # an absolute Windows-style path - self._source_dir = utility.GetAbsolutePath(self._source_dir) + self._source_dir = layout_package.path_utils.GetAbsolutePath( + self._source_dir) valgrind_test_script = os.path.join(script_dir, "valgrind_test.py") self._command_preamble = [valgrind_test_script, "--source_dir=%s" % (self._source_dir)] |