summaryrefslogtreecommitdiffstats
path: root/tools/valgrind/memcheck
diff options
context:
space:
mode:
authormdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-24 17:20:56 +0000
committermdm@chromium.org <mdm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-24 17:20:56 +0000
commit47dd71a6ff0ce51026d35d1ea578c439ae3f2356 (patch)
tree41809910087390cb518c1376f34b3acd67167671 /tools/valgrind/memcheck
parent26bda3b8beab8f23bc46f8ca0a25ebf24c0d5902 (diff)
downloadchromium_src-47dd71a6ff0ce51026d35d1ea578c439ae3f2356.zip
chromium_src-47dd71a6ff0ce51026d35d1ea578c439ae3f2356.tar.gz
chromium_src-47dd71a6ff0ce51026d35d1ea578c439ae3f2356.tar.bz2
Explain one of our valgrind suppressions for sqlite and cite some URLs.
BUG=none TEST=none Review URL: http://codereview.chromium.org/224011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27081 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/memcheck')
-rw-r--r--tools/valgrind/memcheck/suppressions.txt11
1 files changed, 10 insertions, 1 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index d07edae..47cb05b 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -171,7 +171,16 @@
}
{
- # Strange...
+ # "The section of the SQLite library identified works exactly as it should."
+ # http://www.sqlite.org/cvstrac/tktview?tn=536,39
+ # http://www.sqlite.org/cvstrac/tktview?tn=694,39
+ # http://www.sqlite.org/cvstrac/tktview?tn=964,39
+ # This looks like a case where an entire page was allocated, the header and
+ # perhaps some data was written, but the entire buffer was not written to.
+ # The SQLite authors aren't very interested in adding code to clear buffers
+ # for no reason other than pleasing valgrind, but a patch might be accepted
+ # under a macro like SQLITE_SECURE_DELETE which could be construed to apply
+ # to cases like this. (Note that we compile with SQLITE_SECURE_DELETE.)
bug_20653a
Memcheck:Param
write(buf)