summaryrefslogtreecommitdiffstats
path: root/tools/valgrind/memcheck_analyze.py
diff options
context:
space:
mode:
authortimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-21 09:51:38 +0000
committertimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-21 09:51:38 +0000
commitd90fefcf2fd24244d4bd669cdcc500143f62f2e7 (patch)
tree0276af2cbc13e6f4210bc7330ce61995af0a1da2 /tools/valgrind/memcheck_analyze.py
parent90b8ec57d5cbf29330f6f207d567d6c04f71a488 (diff)
downloadchromium_src-d90fefcf2fd24244d4bd669cdcc500143f62f2e7.zip
chromium_src-d90fefcf2fd24244d4bd669cdcc500143f62f2e7.tar.gz
chromium_src-d90fefcf2fd24244d4bd669cdcc500143f62f2e7.tar.bz2
Fix my (??) stupid typo in memcheck_analyze which stupid python didn't caught.
As a result, memcheck_analyze was waiting for dead Valgrind processes for 3 extra minutes. D'oh. BUG=17453,44545 TEST=trybots, experiments by eugenis@ Review URL: http://codereview.chromium.org/6258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72119 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/memcheck_analyze.py')
-rwxr-xr-xtools/valgrind/memcheck_analyze.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/valgrind/memcheck_analyze.py b/tools/valgrind/memcheck_analyze.py
index 5352d5a..a7227d3 100755
--- a/tools/valgrind/memcheck_analyze.py
+++ b/tools/valgrind/memcheck_analyze.py
@@ -418,7 +418,7 @@ class MemcheckAnalyzer:
# 3 minutes if it was killed. See http://crbug.com/17453
ps_out = subprocess.Popen("ps p %s" % pid, shell=True,
stdout=subprocess.PIPE).stdout
- if ps_out.readlines() < 2:
+ if len(ps_out.readlines()) < 2:
running = False
found = find_and_truncate(f)
if not running and not found: