diff options
author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 13:38:43 +0000 |
---|---|---|
committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 13:38:43 +0000 |
commit | f3e0ee5068b65b5828112558547c30aa7af521be (patch) | |
tree | 9b1b474baf8449a73f4654a9c50cb5bc891e7545 /tools/valgrind/memcheck_analyze.py | |
parent | 0ce492992e11845c55dd63115d2b3485fb1e414b (diff) | |
download | chromium_src-f3e0ee5068b65b5828112558547c30aa7af521be.zip chromium_src-f3e0ee5068b65b5828112558547c30aa7af521be.tar.gz chromium_src-f3e0ee5068b65b5828112558547c30aa7af521be.tar.bz2 |
Never create "negative" hashes and output the error hash along with the suppression.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55717 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/memcheck_analyze.py')
-rwxr-xr-x | tools/valgrind/memcheck_analyze.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/valgrind/memcheck_analyze.py b/tools/valgrind/memcheck_analyze.py index 77c5997..8df1610 100755 --- a/tools/valgrind/memcheck_analyze.py +++ b/tools/valgrind/memcheck_analyze.py @@ -250,7 +250,8 @@ class ValgrindError: assert self._suppression != None, "Your Valgrind doesn't generate " \ "suppressions - is it too old?" - output += "Suppression (error hash=#%X#):" % self.__hash__() + output += "Suppression (error hash=#%X#):" % \ + (self.__hash__() & 0xffffffffffffffff) # Widen suppression slightly to make portable between mac and linux supp = self._suppression; supp = supp.replace("fun:_Znwj", "fun:_Znw*") @@ -494,7 +495,7 @@ class MemcheckAnalyzer: # ... but we saw it in earlier reports, e.g. previous UI test cur_report_errors.add("This error was already printed " "in some other test, see 'hash=#%X#'" % \ - error.__hash__()) + (error.__hash__() & 0xffffffffffffffff) else: # ... and we haven't seen it in other tests as well self._errors.add(error) |