summaryrefslogtreecommitdiffstats
path: root/tools/valgrind/valgrind_analyze.py
diff options
context:
space:
mode:
authordkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-17 17:31:10 +0000
committerdkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-17 17:31:10 +0000
commitc714b83711969c1194b53e1c96b4b56ae6128013 (patch)
tree5fde3ae3a1603ad99f5886b06874fd80178451cd /tools/valgrind/valgrind_analyze.py
parentdc82400ec987ed4b155ebd2febfe423105ef6019 (diff)
downloadchromium_src-c714b83711969c1194b53e1c96b4b56ae6128013.zip
chromium_src-c714b83711969c1194b53e1c96b4b56ae6128013.tar.gz
chromium_src-c714b83711969c1194b53e1c96b4b56ae6128013.tar.bz2
Ignore memory leaks in valgrind builder for now.
We'll re-enable them once we fix more serious problems. One would think that passing --leak-check=no to valgrind would suppress leak reports, sadly, --xml=yes forces them on. Review URL: http://codereview.chromium.org/42183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11874 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/valgrind_analyze.py')
-rwxr-xr-xtools/valgrind/valgrind_analyze.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/tools/valgrind/valgrind_analyze.py b/tools/valgrind/valgrind_analyze.py
index 601888a..1c55181 100755
--- a/tools/valgrind/valgrind_analyze.py
+++ b/tools/valgrind/valgrind_analyze.py
@@ -140,7 +140,12 @@ class ValgrindAnalyze:
for file in files:
raw_errors = parse(file).getElementsByTagName("error")
for raw_error in raw_errors:
- self._errors.add(ValgrindError(source_dir, raw_error))
+ # Ignore reachable aka "possible" leaks for now.
+ # Annoyingly, Valgrind's --xml=yes option seems to
+ # force --leak-check=full --show-reachable=yes
+ kind = getTextOf(raw_error, "kind")
+ if (kind != "Leak_PossiblyLost")
+ self._errors.add(ValgrindError(source_dir, raw_error))
def Report(self):
if self._errors: